fix: Allow empty publisher_domains arrays in responses #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… response The JSON Schema defines minItems: 1 for publisher_domains, but real-world agents often return empty arrays when not authorized for any publishers. This fix removes minItems constraints during code generation, allowing empty arrays while maintaining type validation. Also refactored removeMinItemsConstraints() to a shared utility module to eliminate duplication, and added comprehensive tests including edge case validation. 🤖 Generated with Claude Code Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
🤖 Generated with Claude Code Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes validation errors when test agents return empty
publisher_domainsarrays. The upstream JSON Schema definesminItems: 1, but real-world agents return empty arrays when not authorized for any publishers.Changes
schema-utils.tsutility to eliminate code duplicationgenerate-types.tsto removeminItemsconstraints during TypeScript generationgenerate-zod-from-ts.tsto convert tuple patterns to arrays in Zod schemasTest Plan