fix(testing): Use publisher_domains instead of legacy authorized_properties #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erties The discovery and edge-cases test scenarios were reading from the legacy `authorized_properties` field instead of the current v2.3+ field `publisher_domains`. This caused validation failures with the error "publisher_domains.0: Invalid input: expected string, received undefined". Changes: - discovery.ts: Read from publisher_domains (array of strings) instead of authorized_properties (array of objects) - edge-cases.ts: Remove legacy field references, only validate publisher_domains Fixes #183 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
publisher_domains(AdCP v2.3+) instead of legacyauthorized_propertiespublisher_domains, removing legacy field referencespublisher_domainsis an array of strings, not objectsTest plan
publisher_domainsfromlist_authorized_propertiesresponsepublisher_domainsconsistencyFixes #183
🤖 Generated with Claude Code