fix(ci): run packages/eslint-plugin/ tests as part of root npm test (#1766)

[bokelley]

Summary

Closes #1766. Chains npm test --workspaces --if-present onto the root test script so CI's Test & Build job (which runs npm test) exercises the ESLint plugin's rule tests.

The gap. PR #1752 shipped packages/eslint-plugin/ and PR #1762 added 30 rule tests, but neither wired the plugin's test script into root npm test. CI's Test & Build step ran the SDK tests only — plugin regressions could land on main silently.

The fix. Single-line edit to package.json scripts.test:

- "test": "NODE_ENV=test node --test-timeout=60000 --test-force-exit --test test/*.test.js test/lib/*.test.js",
+ "test": "NODE_ENV=test node --test-timeout=60000 --test-force-exit --test test/*.test.js test/lib/*.test.js && npm test --workspaces --if-present",

--workspaces --if-present invokes the test script in every workspace that defines one, and silently skips those that don't — forward-compatible for any future workspace.

Verification

• Plugin standalone: cd packages/eslint-plugin && npm test passes 30/30 (3 suites: no-credential-read-from-args).
• Root invocation: npm test --workspaces --if-present from repo root reaches @adcp/eslint-plugin's test script. Verified the npm dispatch picks it up.
• packages/client-shim/package.json has no test script — --if-present correctly skips it (no behavior change there, and if it ever adds tests they'll be auto-covered).
• CI workflow (.github/workflows/ci.yml, line 86 in the Test & Build job) runs npm test directly, so no workflow edit needed.
• prettier --check clean on changed files.

Test plan

• CI's Test & Build job runs both SDK tests and @adcp/eslint-plugin tests
• Future workspace additions with a test script are automatically exercised by CI

🤖 Generated with Claude Code

[bokelley]

CI recursion fix

Initial commit used npm test --workspaces --if-present, but the root package.json declares "workspaces": [".", "packages/*"] — . is in the workspaces list, so --workspaces re-invokes root's test, which recurses indefinitely. CI's Test & Build cancelled at 13min from the loop.

Fixed by switching to explicit npm test --workspace=packages/eslint-plugin --if-present. Plugin tests run exactly once. New workspaces with test scripts get appended explicitly as a chain — boring and recursion-proof.