Skip to content

ci(adcp-sdk): pin @adcp/sdk to 7.9.0 (last known-green), salt cache key (closes #779 Track B) #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bokelley wants to merge 2 commits into from
+20 −22
Closed

ci(adcp-sdk): pin @adcp/sdk to 7.9.0 (last known-green), salt cache key (closes #779 Track B) #780

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b5380f
ci(adcp-sdk): pin @adcp/sdk to 7.10.1, salt cache key with version
bokelley May 21, 2026
033a2da
ci: retrigger CI on 7.9.0 pin (force-push didn't fire pull_request)
bokelley May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 20 additions & 22 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ on:
pull_request:
branches: [main]

# Pinned @adcp/sdk version. Bump deliberately; cache invalidates when this moves.
# Background: adcontextprotocol/adcp-client-python#779 (Track B), adcontextprotocol/adcp#4907.
env:
ADCP_SDK_VERSION: "7.9.0"

concurrency:
group: ci-${{ github.ref }}
cancel-in-progress: true
Expand Down Expand Up @@ -369,30 +374,25 @@ jobs:

# Cache the npm tarball + extracted package directory so the
# storyboard runner install isn't a cold network fetch every run.
# Key by OS only (not by version) so the cache survives across
# ``@adcp/sdk`` releases — npm install reuses tarballs that are
# already in the cache and only fetches the delta. ``@latest`` is
# intentional for drift detection (see "Run storyboard suite"
# below); the cache amortizes the 5-15 s of fetch+extract that
# would otherwise repeat on every CI run.
# Cache key is salted with the pinned ``@adcp/sdk`` version so
# bumping ADCP_SDK_VERSION invalidates the cache deterministically.
- name: Cache ~/.npm
uses: actions/cache@v4
with:
path: ~/.npm
key: ${{ runner.os }}-npm-adcp-sdk
key: ${{ runner.os }}-npm-adcp-sdk-${{ env.ADCP_SDK_VERSION }}
restore-keys: |
${{ runner.os }}-npm-

- name: Pre-install @adcp/sdk (once, then call binary directly)
# Single install step at the top of the job; subsequent runner
# calls invoke the already-installed binary instead of paying
# the ``npx -y -p ...`` per-invocation extract+link tax.
# ``@adcp/sdk@latest`` is intentionally unpinned: this is AdCP's
# own CI running AdCP's own canonical runner — tracking latest
# surfaces protocol drift as soon as it ships, which is the
# point of this job.
# Pinned to ADCP_SDK_VERSION (see workflow header) — bump via PR
# so reference-impl breakage from a new SDK release shows up as
# a labelled change set, not silent CI flake.
run: |
npm install -g @adcp/sdk@latest
npm install -g @adcp/sdk@${ADCP_SDK_VERSION}
adcp --version

- name: Install dependencies
Expand Down Expand Up @@ -525,15 +525,13 @@ jobs:
with:
node-version: "22"

# Cache ~/.npm by OS only so subsequent runs hit the tarball
# cache; npm install reuses what's there and only fetches the
# delta on a new ``@latest`` release. See the storyboard job
# above for the same pattern + rationale.
# Same cache pattern as the storyboard job: keyed by
# ADCP_SDK_VERSION so a bump invalidates deterministically.
- name: Cache ~/.npm
uses: actions/cache@v4
with:
path: ~/.npm
key: ${{ runner.os }}-npm-adcp-sdk
key: ${{ runner.os }}-npm-adcp-sdk-${{ env.ADCP_SDK_VERSION }}
restore-keys: |
${{ runner.os }}-npm-

Expand All @@ -549,7 +547,7 @@ jobs:

- name: Pre-install @adcp/sdk (once, then call binary directly)
run: |
npm install -g @adcp/sdk@latest
npm install -g @adcp/sdk@${ADCP_SDK_VERSION}
adcp --version

- name: Start JS mock-server upstream
Expand Down Expand Up @@ -752,13 +750,13 @@ jobs:
uses: actions/cache@v4
with:
path: ~/.npm
key: ${{ runner.os }}-npm-adcp-sdk
key: ${{ runner.os }}-npm-adcp-sdk-${{ env.ADCP_SDK_VERSION }}
restore-keys: |
${{ runner.os }}-npm-

- name: Pre-install @adcp/sdk
run: |
npm install -g @adcp/sdk@latest
npm install -g @adcp/sdk@${ADCP_SDK_VERSION}
adcp --version

- name: Install dependencies
Expand Down Expand Up @@ -853,13 +851,13 @@ jobs:
uses: actions/cache@v4
with:
path: ~/.npm
key: ${{ runner.os }}-npm-adcp-sdk
key: ${{ runner.os }}-npm-adcp-sdk-${{ env.ADCP_SDK_VERSION }}
restore-keys: |
${{ runner.os }}-npm-

- name: Pre-install @adcp/sdk
run: |
npm install -g @adcp/sdk@latest
npm install -g @adcp/sdk@${ADCP_SDK_VERSION}
adcp --version

- name: Install dependencies
Expand Down
Loading