docs(adcp): fix a2a-sdk 1.0.x symbol guidance in v3→v4 migration guide#524
Merged
Merged
Conversation
MIGRATION_v3_to_v4.md told adopters that `a2a.utils.errors.ServerError` migrates to `a2a.types.A2AError` and `a2a.types.DataPart` migrates to `a2a.types.MessagePart`. Neither `a2a.types.A2AError` nor `a2a.types.MessagePart` exist in a2a-sdk 1.0.1 (the version this SDK pins). The error base is at `a2a.utils.errors.A2AError`; `DataPart` and `TextPart` are replaced by `a2a.types.Part` (a protobuf message with a `content` oneof); `MessagePart` does not exist at all. Replace the one-line "verify against your usage" punt with two concrete subsections: - Hand-rolled 0.3 servers: no mechanical migration path; recommend deleting the hand-rolled server and using `adcp.server.serve(transport="a2a")`. - Direct `a2a` type imports: correct before/after for DataPart, TextPart, Part wrapper, and ServerError with proper module paths. Also corrects the version specifier from `>=1.0.0` to `>=1.0.1,<1.0.2` to match the actual pin in pyproject.toml. Closes #514 https://claude.ai/code/session_015ztuszM5hAJG7N5NcA9acB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #514
Summary
MIGRATION_v3_to_v4.mdtold adopters thata2a.utils.errors.ServerErrormigrates toa2a.types.A2AErroranda2a.types.DataPartmigrates toa2a.types.MessagePart. Neithera2a.types.A2AErrornora2a.types.MessagePartexist ina2a-sdk==1.0.1(the version this SDK pins). A real adopter (salesagent v3→v4 migration) gated an entire module behindA2A_LEGACY_AVAILABLEand skipped 6 test modules because the guide pointed at dead symbols.This PR replaces the one-liner "see release notes" with two concrete subsections:
adcp.server.serve(transport="a2a").a2atype imports — correct symbol table:DataPart/TextPart→a2a.types.Part;Part(root=...)wrapper →Partdirectly;ServerError→a2a.utils.errors.A2AError; and explicit note thata2a.types.A2AErroranda2a.types.MessagePartdo not exist.Also corrects the version specifier in the prose from
>=1.0.0to>=1.0.1,<1.0.2to match the actual pin.What tested
A2AErrorpath verified againstsrc/adcp/server/translate.py:32DataPart/TextPart/Partsemantics verified againsttests/a2a_compat_shim.py:116–129a2a.server.routes+a2a.server.agent_executionpaths verified againstsrc/adcp/server/a2a_server.py:28–37>=1.0.1,<1.0.2and regression comment verified inpyproject.toml:51–57Pre-PR review
pyproject.tomlcomment is accurate and sufficient)Session: https://claude.ai/code/session_015ztuszM5hAJG7N5NcA9acB
Generated by Claude Code