feat(types,decisioning): close salesagent migration export gaps#511
Merged
Conversation
Adds public-surface exports for symbols adopters import in practice but that previously required reaching into ``adcp.types.generated_poc.*`` or ``adcp.decisioning.dispatch``: - ``adcp.types``: ``Dimensions``, ``Renders`` (paired with the already-public ``Responsive`` triad in core.format), plus ``MediaBuyFeatures`` and ``AiTool`` (both referenced from 5+ adopter call sites). - ``adcp.decisioning.validate_capabilities``: re-export ``validate_platform`` so the module name matches its purpose. Also added at ``adcp.decisioning`` top level for symmetry with the rest of the decisioning surface. Driven by salesagent v3.12 → 4.x migration feedback (items #1, #2, #8). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Reflects the four additions from the previous commit (Dimensions, Renders, MediaBuyFeatures, AiTool). Snapshot diff is purely additive. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DimensionsandRenderstoadcp.types(pair with the already-publicResponsivetriad).MediaBuyFeaturesandAiTooltoadcp.types(referenced from 5+ adopter call sites).validate_platformfromadcp.decisioning.validate_capabilitiesand from theadcp.decisioningtop level — the module name reads like the right home, but the function lived inadcp.decisioning.dispatch.Motivation
Lifted directly from the salesagent v3.12 → 4.x migration write-up — items #1, #2, and #8 in
SDK_FEEDBACK.md. These are pure mechanical wins that unblock six tests salesagent had to revert to mixedgenerated_pocimports, and align the module namevalidate_capabilitieswith the function adopters expect to find there.No behavior change, no schema change. Existing import paths (
generated_poc/*,adcp.decisioning.dispatch.validate_platform) continue to work.Test plan
ruff checkclean on touched filesmypyclean on touched filespytest tests/test_capabilities_response_shape_validation.py tests/test_decisioning_dispatch.py— 45 passedpytest -k "types_export or public_surface or aliases or generated"— 119 passedadcp.typessymbols and the twovalidate_platformpaths resolve to the same callableadcp.typesimportsFollow-ups (not in this PR)
The salesagent feedback list has 12 more items. I'll file them as separate issues for triage — the highest-leverage one is the codemod
--auto-applymode (78% of findings are mechanically rewritable today).🤖 Generated with Claude Code