Alexa Coffman - Whales #94
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidamasaki
reviewed
Jul 19, 2022
kaidamasaki
left a comment
kaidamasaki
left a comment
There was a problem hiding this comment.
Great job!
I left one note about semantic HTML but everything else looks good.
Well done!
| import ChatLog from './components/ChatLog'; | ||
| import chatMessages from './data/messages.json'; | ||
|
|
||
| let totalLikes = 0; |
There was a problem hiding this comment.
totalLikes should have been stored in a useState variable.
When you update state in React it triggers a re-render automatically. Updating a global variable won't. (Also if you instantiated the app twice on the same page you'd be in trouble.)
| <h1>Application title</h1> | ||
| <h1>Chat between Vladimir and Estragon</h1> | ||
| <section className="header section"> | ||
| <h4 id="heartWidget" className="widget"> |
There was a problem hiding this comment.
Remember, the h1, h2, etc. elements should be used to denote the structure of the page (you should be able to build a table of contents).
If you want to change the size of text you should use CSS.
Comment on lines
+9
to
+18
| <section> | ||
| <ChatEntry | ||
| id={chatEntry.id} | ||
| sender={chatEntry.sender} | ||
| body={chatEntry.body} | ||
| timeStamp={chatEntry.timeStamp} | ||
| liked={chatEntry.liked} | ||
| onUpdate={props.onUpdateEntry} | ||
| ></ChatEntry> | ||
| </section> |
There was a problem hiding this comment.
This extra section doesn't hurt anything but isn't required, FYI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.