C17 Whales - Grace Park #87
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…estamp not visible
…ve 3 tests pass individually
…l or remote (optional enhancement)
kaidamasaki
reviewed
Jul 21, 2022
kaidamasaki
left a comment
kaidamasaki
left a comment
There was a problem hiding this comment.
Great job!
I left a few small notes but everything else looks good.
Well done!
| <h1> | ||
| Chat between {chatMessages[0].sender} and {chatMessages[1].sender} | ||
| </h1> | ||
| <h2> {countLiked()} ❤️s</h2> |
There was a problem hiding this comment.
Style: This should be a section or p or something since h1, h2, etc should be reserved for titles of parts of the page and this doesn't actually have content associated with it.
Comment on lines
+43
to
+46
| {/* <ChatEntry | ||
| sender={senderData} | ||
| body={bodyData} | ||
| timeStamp={timeStampData} |
There was a problem hiding this comment.
Style: It's industry standard to remove commented out code before submitting a PR.
|
|
||
| // determine local or remote sender | ||
| const senderType = | ||
| props.sender === 'Vladimir' ? 'chat-entry local' : 'chat-entry remote'; |
There was a problem hiding this comment.
Tip: This is a little brittle since it means we couldn't re-use these components for a chat between other people.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.