Conversation
|
Claude finished @khustup2's task in 1m 16s —— View job PR Review CompleteI've reviewed the changes to remove PostgreSQL 16 support. The removal is generally clean and consistent across the codebase: Changes reviewed:
Issue found:
The code changes are technically sound, but please clarify whether dropping PG 14/15 support is intentional. |
| psql_version=$(psql -V | awk '{print $3}' | cut -d'.' -f1) | ||
| case "$psql_version" in | ||
| 14 | 15 | 16 | 17) | ||
| 17 | 18) |
There was a problem hiding this comment.
The version check was changed from 14 | 15 | 16 | 17 to only 17 | 18, which drops support for PostgreSQL 14 and 15 in addition to 16. This seems like an unintended breaking change since the PR title only mentions removing PG 16 support.
If PostgreSQL 14 and 15 support should also be removed, this should be documented in the PR description and the title should reflect the broader scope.
|



🚀 🚀 Pull Request
Impact
Description
Things to be aware of
Things to worry about
Additional Context