Skip to content

Comments

Removed 16 pg support.#3140

Merged
khustup2 merged 3 commits intomainfrom
drop-pg16-support
Feb 14, 2026
Merged

Removed 16 pg support.#3140
khustup2 merged 3 commits intomainfrom
drop-pg16-support

Conversation

@khustup2
Copy link
Contributor

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

@claude
Copy link

claude bot commented Feb 14, 2026

Claude finished @khustup2's task in 1m 16s —— View job


PR Review Complete

I've reviewed the changes to remove PostgreSQL 16 support. The removal is generally clean and consistent across the codebase:

Changes reviewed:

  • ✅ GitHub workflow updated to remove PG 16 from build matrix
  • ✅ CMake configuration cleaned up (removed BUILD_PG_16 option)
  • ✅ PostgreSQL version detection logic updated
  • ✅ C++ version compatibility headers cleaned up
  • ✅ Conditional compilation guards removed (now assumes PG 17+)
  • ✅ Build scripts updated with correct version examples
  • ✅ Python build script updated to reflect supported versions

Issue found:

  • ⚠️ The install.sh script drops support for PostgreSQL 14 and 15 in addition to 16, which appears to be an unintended breaking change. See inline comment.

The code changes are technically sound, but please clarify whether dropping PG 14/15 support is intentional.


psql_version=$(psql -V | awk '{print $3}' | cut -d'.' -f1)
case "$psql_version" in
14 | 15 | 16 | 17)
17 | 18)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version check was changed from 14 | 15 | 16 | 17 to only 17 | 18, which drops support for PostgreSQL 14 and 15 in addition to 16. This seems like an unintended breaking change since the PR title only mentions removing PG 16 support.

If PostgreSQL 14 and 15 support should also be removed, this should be documented in the PR description and the title should reflect the broader scope.

@sonarqubecloud
Copy link

@khustup2 khustup2 merged commit 12b501e into main Feb 14, 2026
6 checks passed
@khustup2 khustup2 deleted the drop-pg16-support branch February 14, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant