Fix bug that .order breaks the order of original records

[ytakhs]

This PR fixes #193

class Country < ActiveHash::Base
  field :name
  field :language
  self.data = [
    {:id => 1, :name => "US", :language => 'English'},
    {:id => 2, :name => "Canada", :language => 'English'},
    {:id => 3, :name => "Mexico", :language => 'Spanish'}
  ]
end

p Country.first.name
#=> "US"
Country.order(id: :desc)
p Country.first.name
#=> "Mexico"

#filter_all_records_by_query_hash returns all_records without copy when query_hash is empty, so Array#sort! breaks the order of original records.

Thanks.

[kbrock]

With this implementation, I wonder if we need reorder as well.

aside: this implementation is getting closer to active record's implementation of sorting. that is good

[littleforest]

I'm wondering what the status of this PR is? I've been affected by #193, and have kept using version 2.3 to avoid this bug, but I am now needing to upgrade to Ruby 3. Could this PR be moved along (or closed if it is not the correct way to solve the issue?)

[castlese]

@littleforest how did you end up addressing your problem? We are in the same situation right now, reliant on an old branch but need to upgrade ruby

[littleforest]

@castlese I just redefined the order method in my model:

    def self.order(field)
      all.sort_by { |hash| hash[field] }
    end

Also, I do seem to still be using version 2.3 in one of my Ruby 3 apps, so you don't necessarily need to upgrade I don't think.

[kbrock]

Thank you for helping us with this solution. Going with #268 instead