Skip to content

Conversation

@Jarvis1105
Copy link
Collaborator

@Jarvis1105 Jarvis1105 commented Dec 31, 2025

User description

assign in @LordofAvernus

关联的 issue

https://github.com/actiontech/dms-ee/issues/712

描述你的变更

  • 修复同步SQL Server数据源到odc的枚举报错问题

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已记录完整日志方便进行诊断
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc


Description

  • 修正 SQL Server 类型映射错误

  • 修改条件字符串和返回值格式


Diagram Walkthrough

flowchart LR
  A["读取数据库类型"] --> B["判断条件"]
  B -- "SQL Server" --> C["返回 SQL_SERVER"]
Loading

File Walkthrough

Relevant files
Bug fix
sql_workbench_service.go
更新 SQL Server 映射逻辑                                                                             

internal/sql_workbench/service/sql_workbench_service.go

  • 修改 SQL Server 条件判断字符串
  • 更新返回值从 "SQLSERVER" 改为 "SQL_SERVER"
+2/-2     

@github-actions
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

SQL映射检查

新增的 "SQL Server" 映射变更需要确认与系统其他模块的数据类型判断逻辑保持一致,同时确保返回值 "SQL_SERVER" 与预期匹配,以避免数据源创建流程出错。

case "SQL Server":
	return "SQL_SERVER"

@github-actions
Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

@LordofAvernus LordofAvernus merged commit 6dce122 into main Dec 31, 2025
1 check passed
BugsGuru pushed a commit that referenced this pull request Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants