Don't download releases-index.json to resolve major version by akoeplinger · Pull Request #560 · actions/setup-dotnet

akoeplinger · 2024-11-07T13:38:19Z

Description:
Starting with .NET 5 the minor version is always zero. The earlier releases don't get new versions anymore so we can hardcode the minor version instead of downloading releases-index.json to do the lookup.

Check list:

Mark if documentation changes are required.
Mark if tests were added or updated to cover the changes.

Starting with .NET 5 the minor version is always zero. The earlier releases don't get new versions anymore so we can hardcode the minor version instead of downloading releases-index.json to do the lookup.

akoeplinger · 2024-11-25T14:59:16Z

ping?

akoeplinger · 2025-03-24T17:23:23Z

@HarithaVattikuti would you mind reviewing this? thanks

akoeplinger · 2026-04-10T12:18:34Z

ping

Frulfump · 2026-04-11T03:34:26Z

ping

It's insane this repo sees so little activity from the maintainers when just using an agent could close 90% of issues by triage and opening PRs and reviewing open PRs.

Can't you escalate internally?

akoeplinger · 2026-04-11T07:28:40Z

yeah. I'm on vacation for the next few weeks but will see what I can do when I'm back

Frulfump · 2026-04-14T08:52:36Z

:O maintainer interaction 5-6 hours ago, closing and re-opening the PR. Any chance to get anything more @HarithaVattikuti ?

priya-kinthali · 2026-04-16T06:25:32Z

Hi @akoeplinger👋, thanks for the contribution!
We have noticed that the CI checks are currently failing due to a formatting issue in src/installer.ts. Could you please run the following commands locally and commit the results?

npm run format
npm run build

This should fix the Prettier formatting error and ensure the build output is up to date. Please let us know in case of any issues.

Copilot

Pull request overview

This PR simplifies .NET channel resolution for major-only version inputs by avoiding a network call to releases-index.json, based on the assumption that .NET 5+ channels always use a .0 minor and that .NET Core 1–3 no longer change.

Changes:

Remove the @actions/http-client-based lookup of releases-index.json for resolving major-only version inputs.
Hardcode major-to-channel mappings for .NET Core 1–3 and default to ${major}.0 for other numeric majors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

akoeplinger · 2026-04-16T09:32:07Z

@priya-kinthali done, thanks

…otnet into fix-releases

akoeplinger · 2026-04-16T14:36:32Z

@priya-kinthali forgot to commit the dist/ file, fixed. there also seems to be a new npm audit error that looks unrelated to the PR

akoeplinger · 2026-04-17T10:18:18Z

can you please trigger CI again, I think the check-dist should be fixed now

priya-kinthali · 2026-04-29T05:25:31Z

Hi @akoeplinger👋, Thanks for quick updates! It looks like this PR has some merge conflicts. Could you please sync with the latest changes from main so we can proceed with merging? Thanks again!

Frulfump · 2026-04-29T14:29:07Z

Hi @akoeplinger👋, Thanks for quick updates! It looks like this PR has some merge conflicts. Could you please sync with the latest changes from main so we can proceed with merging? Thanks again!

The latest action runs for main fails with npm audit (as reported earlier), will you merge on red after syncing anyways?
(And can't you rebase the branch as maintainers?)

# Conflicts: # dist/setup/index.js # src/installer.ts

akoeplinger · 2026-05-07T11:20:01Z

@priya-kinthali merged main, please rerun CI, thanks!

akoeplinger · 2026-05-11T15:00:38Z

The Basic validation failures are unrelated and are due to #731

Frulfump · 2026-05-11T18:07:11Z

Amazing this got merged, only took 1,5 years.

Let's hope
#538
#717

Could get some love as well

The PR sat for roughly 18 months despite being small, reviewable, and eventually mergeable. The author pinged multiple times. Once maintainers engaged, the remaining issues were routine formatting/build/review items, which strongly suggests the bottleneck was project triage and ownership, not technical complexity.

Timeline
PR opened: 2024-11-07
author ping: 2024-11-25
author asks for review: 2025-03-24
author pings again: 2026-04-10
visible maintainer interaction resumes: around 2026-04-14 to 2026-04-16
PR merged: 2026-05-11

Bumps the github-actions group with 2 updates: [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) and [actions/setup-dotnet](https://github.com/actions/setup-dotnet). Updates `docker/setup-qemu-action` from 4.0.0 to 4.1.0 Release notes *Sourced from [docker/setup-qemu-action's releases](https://github.com/docker/setup-qemu-action/releases).* > v4.1.0 > ------ > > * Add `reset` input to uninstall current emulators by [`@crazy-max`](https://github.com/crazy-max) in [docker/setup-qemu-action#21](https://redirect.github.com/docker/setup-qemu-action/pull/21) > * Bump `@docker/actions-toolkit` from 0.77.0 to 0.91.0 in [docker/setup-qemu-action#250](https://redirect.github.com/docker/setup-qemu-action/pull/250) [docker/setup-qemu-action#247](https://redirect.github.com/docker/setup-qemu-action/pull/247) > * Bump brace-expansion from 1.1.12 to 1.1.15 in [docker/setup-qemu-action#265](https://redirect.github.com/docker/setup-qemu-action/pull/265) > * Bump fast-xml-builder from 1.0.0 to 1.2.0 in [docker/setup-qemu-action#286](https://redirect.github.com/docker/setup-qemu-action/pull/286) > * Bump fast-xml-parser from 5.4.2 to 5.8.0 in [docker/setup-qemu-action#255](https://redirect.github.com/docker/setup-qemu-action/pull/255) > * Bump flatted from 3.3.3 to 3.4.2 in [docker/setup-qemu-action#257](https://redirect.github.com/docker/setup-qemu-action/pull/257) > * Bump glob from 10.3.15 to 10.5.0 in [docker/setup-qemu-action#254](https://redirect.github.com/docker/setup-qemu-action/pull/254) > * Bump handlebars from 4.7.8 to 4.7.9 in [docker/setup-qemu-action#262](https://redirect.github.com/docker/setup-qemu-action/pull/262) > * Bump lodash from 4.17.23 to 4.18.1 in [docker/setup-qemu-action#273](https://redirect.github.com/docker/setup-qemu-action/pull/273) > * Bump postcss from 8.5.6 to 8.5.10 in [docker/setup-qemu-action#285](https://redirect.github.com/docker/setup-qemu-action/pull/285) > * Bump tar from 6.2.1 to 7.5.15 in [docker/setup-qemu-action#287](https://redirect.github.com/docker/setup-qemu-action/pull/287) > * Bump tmp from 0.2.5 to 0.2.6 in [docker/setup-qemu-action#291](https://redirect.github.com/docker/setup-qemu-action/pull/291) > * Bump undici from 6.23.0 to 6.26.0 in [docker/setup-qemu-action#251](https://redirect.github.com/docker/setup-qemu-action/pull/251) > * Bump vite from 7.3.1 to 7.3.2 in [docker/setup-qemu-action#271](https://redirect.github.com/docker/setup-qemu-action/pull/271) > > **Full Changelog**: <docker/setup-qemu-action@v4.0.0...v4.1.0> Commits * [`0611638`](docker/setup-qemu-action@0611638) Merge pull request [#21](https://redirect.github.com/docker/setup-qemu-action/issues/21) from crazy-max/uninst * [`ce59c81`](docker/setup-qemu-action@ce59c81) chore: update generated content * [`2ddad44`](docker/setup-qemu-action@2ddad44) uninstall current emulators * [`8c37cd6`](docker/setup-qemu-action@8c37cd6) Merge pull request [#250](https://redirect.github.com/docker/setup-qemu-action/issues/250) from docker/dependabot/npm\_and\_yarn/docker/actions-to... * [`d1a0ff3`](docker/setup-qemu-action@d1a0ff3) chore: update generated content * [`0a8f3dc`](docker/setup-qemu-action@0a8f3dc) build(deps): bump `@docker/actions-toolkit` from 0.79.0 to 0.91.0 * [`9430f61`](docker/setup-qemu-action@9430f61) Merge pull request [#291](https://redirect.github.com/docker/setup-qemu-action/issues/291) from docker/dependabot/npm\_and\_yarn/tmp-0.2.6 * [`978bd77`](docker/setup-qemu-action@978bd77) chore: update generated content * [`3479feb`](docker/setup-qemu-action@3479feb) build(deps): bump tmp from 0.2.5 to 0.2.6 * [`b113c26`](docker/setup-qemu-action@b113c26) Merge pull request [#255](https://redirect.github.com/docker/setup-qemu-action/issues/255) from docker/dependabot/npm\_and\_yarn/fast-xml-parser-5... * Additional commits viewable in [compare view](docker/setup-qemu-action@ce36039...0611638) Updates `actions/setup-dotnet` from 5.2.0 to 5.3.0 Release notes *Sourced from [actions/setup-dotnet's releases](https://github.com/actions/setup-dotnet/releases).* > v5.3.0 > ------ > > What's Changed > -------------- > > ### Enhancements > > * Add dotnet-version: latest support with dotnet-channel input by [`@mahabaleshwars`](https://github.com/mahabaleshwars) in [actions/setup-dotnet#730](https://redirect.github.com/actions/setup-dotnet/pull/730) > * Support global.json's rollForward latest\* variants by [`@js6pak`](https://github.com/js6pak) in [actions/setup-dotnet#538](https://redirect.github.com/actions/setup-dotnet/pull/538) > * Improve version resolution by [`@akoeplinger`](https://github.com/akoeplinger) in [actions/setup-dotnet#560](https://redirect.github.com/actions/setup-dotnet/pull/560) > > ### Dependency Updates > > * Upgrade @actions/\* and fast-xml-parser dependencies by [`@Copilot`](https://github.com/Copilot) in [actions/setup-dotnet#728](https://redirect.github.com/actions/setup-dotnet/pull/728) > * Update install scripts to v2026.05.19 (preserve archive links) by [`@MichaelSimons`](https://github.com/MichaelSimons) in [actions/setup-dotnet#736](https://redirect.github.com/actions/setup-dotnet/pull/736) > * Add rollForward note in README, improve proxy health check in e2e tests and bump version to v5.3.0 by [`@priyagupta108`](https://github.com/priyagupta108) in [actions/setup-dotnet#738](https://redirect.github.com/actions/setup-dotnet/pull/738) > > ### Bug Fixes > > * Update Test Proxy job by [`@priya-kinthali`](https://github.com/priya-kinthali) in [actions/setup-dotnet#703](https://redirect.github.com/actions/setup-dotnet/pull/703) > > New Contributors > ---------------- > > * [`@Copilot`](https://github.com/Copilot) made their first contribution in [actions/setup-dotnet#728](https://redirect.github.com/actions/setup-dotnet/pull/728) > * [`@akoeplinger`](https://github.com/akoeplinger) made their first contribution in [actions/setup-dotnet#560](https://redirect.github.com/actions/setup-dotnet/pull/560) > * [`@MichaelSimons`](https://github.com/MichaelSimons) made their first contribution in [actions/setup-dotnet#736](https://redirect.github.com/actions/setup-dotnet/pull/736) > * [`@js6pak`](https://github.com/js6pak) made their first contribution in [actions/setup-dotnet#538](https://redirect.github.com/actions/setup-dotnet/pull/538) > > **Full Changelog**: <actions/setup-dotnet@v5...v5.3.0> Commits * [`9a946fd`](actions/setup-dotnet@9a946fd) Add rollForward note in README, improve proxy health check in e2e tests and b... * [`98af08b`](actions/setup-dotnet@98af08b) Support global.json's rollForward latest\* variants ([#538](https://redirect.github.com/actions/setup-dotnet/issues/538)) * [`8404272`](actions/setup-dotnet@8404272) Update install scripts to v2026.05.19 ([#736](https://redirect.github.com/actions/setup-dotnet/issues/736)) * [`f1970f5`](actions/setup-dotnet@f1970f5) Don't download releases-index.json to resolve major version ([#560](https://redirect.github.com/actions/setup-dotnet/issues/560)) * [`af9211b`](actions/setup-dotnet@af9211b) Add dotnet-version: latest support with dotnet-channel input ([#730](https://redirect.github.com/actions/setup-dotnet/issues/730)) * [`df991ae`](actions/setup-dotnet@df991ae) chore: bump @actions/\* and fast-xml-parser dependencies ([#728](https://redirect.github.com/actions/setup-dotnet/issues/728)) * [`a66eefa`](actions/setup-dotnet@a66eefa) CI: remove manual PowerShell install from test-proxy job (e2e-tests.yml) ([#703](https://redirect.github.com/actions/setup-dotnet/issues/703)) * See full diff in [compare view](actions/setup-dotnet@c2fa09f...9a946fd) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore ` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore ` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore ` will remove the ignore condition of the specified dependency and ignore conditions

Don't download releases-index.json to resolving major version

c846dff

Starting with .NET 5 the minor version is always zero. The earlier releases don't get new versions anymore so we can hardcode the minor version instead of downloading releases-index.json to do the lookup.

akoeplinger requested a review from a team as a code owner November 7, 2024 13:38

akoeplinger changed the title ~~Don't download releases-index.json to resolving major version~~ Don't download releases-index.json to resolve major version Nov 7, 2024

Merge branch 'main' into fix-releases

d3c6b46

HarithaVattikuti closed this Apr 14, 2026

HarithaVattikuti reopened this Apr 14, 2026

akoeplinger added 2 commits April 16, 2026 14:06

Merge remote-tracking branch 'origin/main' into fix-releases

cf10840

Remove unused variable

2f7b482

Copilot AI review requested due to automatic review settings April 16, 2026 09:12

Copilot started reviewing on behalf of akoeplinger April 16, 2026 09:12 View session

Copilot AI reviewed Apr 16, 2026

View reviewed changes

Comment thread src/installer.ts Outdated

Comment thread src/installer.ts Outdated

Comment thread src/installer.ts Outdated

Comment thread src/installer.ts Outdated

Apply suggestions from code review

58c3d85

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

akoeplinger added 2 commits April 16, 2026 19:30

Commit dist/setup/index.js

102a3ad

Merge branch 'fix-releases' of https://github.com/akoeplinger/setup-d…

66d4461

…otnet into fix-releases

Frulfump mentioned this pull request Apr 16, 2026

Expand the CSC problem matcher to light up more errors on GitHub. #717

Open

2 tasks

Refresh after copilot commits

ac80f3f

mahabaleshwars previously approved these changes Apr 22, 2026

View reviewed changes

priya-kinthali previously approved these changes Apr 22, 2026

View reviewed changes

Merge branch 'main' into fix-releases

15bb176

# Conflicts: # dist/setup/index.js # src/installer.ts

akoeplinger dismissed stale reviews from priya-kinthali and mahabaleshwars via 15bb176 May 7, 2026 11:18

mahabaleshwars approved these changes May 8, 2026

View reviewed changes

HarithaVattikuti approved these changes May 11, 2026

View reviewed changes

HarithaVattikuti merged commit f1970f5 into actions:main May 11, 2026
111 of 114 checks passed

akoeplinger deleted the fix-releases branch May 21, 2026 16:18

Conversation

akoeplinger commented Nov 7, 2024

Uh oh!

akoeplinger commented Nov 25, 2024

Uh oh!

akoeplinger commented Mar 24, 2025

Uh oh!

akoeplinger commented Apr 10, 2026

Uh oh!

Frulfump commented Apr 11, 2026

Uh oh!

akoeplinger commented Apr 11, 2026

Uh oh!

Frulfump commented Apr 14, 2026

Uh oh!

priya-kinthali commented Apr 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

akoeplinger commented Apr 16, 2026

Uh oh!

akoeplinger commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akoeplinger commented Apr 17, 2026

Uh oh!

priya-kinthali commented Apr 29, 2026

Uh oh!

Frulfump commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akoeplinger commented May 7, 2026

Uh oh!

akoeplinger commented May 11, 2026

Uh oh!

Uh oh!

Frulfump commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

akoeplinger commented Apr 16, 2026 •

edited

Loading

Frulfump commented Apr 29, 2026 •

edited

Loading

Frulfump commented May 11, 2026 •

edited

Loading