[helmchart] customize dind container resources limits#3799
Closed
joosangkim wants to merge 2 commits intoactions:masterfrom
Closed
[helmchart] customize dind container resources limits#3799joosangkim wants to merge 2 commits intoactions:masterfrom
joosangkim wants to merge 2 commits intoactions:masterfrom
Conversation
joosangkim
requested review from
a team,
mumoshu,
rentziass and
toast-gear
as code owners
joosangkim
changed the title
|
also covered here: #3645. no reaction from the maintainers for months... |
RawandGuiga
approved these changes
Feb 20, 2025
|
We can now customise resource limits at the pod level: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#pod-level-resource-specification Maybe that helps alleviate your need for this? As it did for me |
Collaborator
|
Closing this one since customizations to dind container are possible now with experimental charts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently dind container has no
resourceskey, it causes difficulties at monitoring self-hosted runners usage.This PR is about customizing dind container's resource limit by users taste and also it has default value as same as github hosted runners for private repositories.