improve(spokepool): Support TVM deposits#3261
Conversation
pxrl
requested review from
bmzig,
dijanin-brat,
mrice32 and
nicholaspai
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ade3c9996a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Route writes through TransactionClient so TVM origins (TRON) flow through the | ||
| // TronWeb submission path. The ethers direct-send path requires `eth_getTransactionCount`, | ||
| // which TRON's JSON-RPC compat layer does not implement. | ||
| const txnClient = new TransactionClient(logger, [signer]); |
There was a problem hiding this comment.
The new TVM transaction path is effectively unreachable because deposit() still aborts non-EVM origins with assert(chainIsEvm(fromChainId)) earlier in the function, so running this script with a TVM origin (for example TRON 728126428) throws before approval/deposit submission. That means the commit does not actually support TVM-origin deposits in practice and users get an assertion failure instead of a deposit flow.
Useful? React with 👍 / 👎.
2 participants
No description provided.