chore: Deploy script update#1436
Conversation
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
fusmanii
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4be777f5e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…isal/deploy-scripts
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
|
@codex review |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c5aa03fe32
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (block.chainid == 999) { | ||
| donationBox.grantRole(donationBox.WITHDRAWER_ROLE(), address(sponsoredCCTPDstPeriphery)); | ||
| } else { | ||
| donationBox.grantRole(donationBox.WITHDRAWER_ROLE(), address(multicallHandler)); |
There was a problem hiding this comment.
For non-999 deployments this branch grants WITHDRAWER_ROLE only to multicallHandler, but SponsoredCCTPDstPeriphery executes sponsorship logic through delegatecalls that invoke donationBox.withdraw(...) from the periphery context. That means on those chains sponsored flows will revert with AccessControl when they need DonationBox funds. The previous script granted the role to the destination periphery, which is required for these withdrawal paths to work.
Useful? React with 👍 / 👎.
| vm.stopBroadcast(); | ||
|
|
||
| config.set("sponsoredCCTPDstPeriphery", address(sponsoredCCTPDstPeriphery)); | ||
| config.set(string.concat("sponsoredCCTPDstPeriphery_", tokenName), address(sponsoredCCTPDstPeriphery)); |
There was a problem hiding this comment.
This change only writes sponsoredCCTPDstPeriphery_<token> and no longer updates the canonical sponsoredCCTPDstPeriphery key. Existing operational scripts in this repo (for example script/mintburn/cctp/SetUpTokens.s.sol and script/mintburn/cctp/createLighterDeposit.s.sol) still read the canonical key, so after deployment they will target a stale/old address instead of the newly deployed contract.
Useful? React with 👍 / 👎.
1 participant
No description provided.