feat(SpokePoolPeriphery): support extended ERC-3009 bytes-signature#1420
Open
mrice32 wants to merge 1 commit into
Open
feat(SpokePoolPeriphery): support extended ERC-3009 bytes-signature#1420mrice32 wants to merge 1 commit into
mrice32 wants to merge 1 commit into
Conversation
Adds depositWithAuthorizationBytes and swapAndBridgeWithAuthorizationBytes to pull tokens via the extended EIP-3009 receiveWithAuthorization overload that takes an unstructured bytes signature (e.g. USDC v2.2). This unlocks contract-wallet (EIP-1271) signers, in addition to the existing v/r/s form which is restricted to EOA/ECDSA signatures. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SpokePoolPeripherythat pull tokens via the extended EIP-3009receiveWithAuthorization(...,bytes signature)overload (e.g. USDC v2.2):depositWithAuthorizationBytesswapAndBridgeWithAuthorizationBytesIERC20AuthBytesinterface alongsideIERC20Auth. Selectors differ from the canonical v/r/sreceiveWithAuthorization, so a token can implement both — and our periphery now supports either.MockERC20gains the bytes overload (sharing verification logic with the v/r/s overload) so we can exercise both code paths.Test plan
yarn build-evm-foundryyarn test-evm-foundry -- --match-contract SpokePoolPeripheryTest— 33 passed (existing 29 + 4 new)testTransferWithAuthBytesDepositValidWitness— happy path, EOA signertestTransferWithAuthBytesSwapAndBridgeValidWitness— happy path, swap + bridgetestTransferWithAuthBytesSwapAndBridgeInvalidWitness— wrong witness reverts (fuzz)testTransferWithAuthBytesDepositEIP1271ContractSigner— proves a contract wallet can deposit, which is impossible via the v/r/s entry pointsyarn lint-fix🤖 Generated with Claude Code