major mods for cmdline params, one script for desktop/android, etc. … #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…un_test.py is now the main test
acreskeyMoz
reviewed
Sep 1, 2020
| "--iterations", | ||
| type=int, | ||
| default=3, | ||
| help="Number of iterations", |
Owner
There was a problem hiding this comment.
Nice, these arguments are a good addition.
Owner
|
@jesup I've pushed this PR to a branch in case you need it directly in the future. |
Also updated the site list
Docs updated to reflect android/desktop capabilities
…scripts into main
Added these options: -specify output path (defaults to "browsertime-results") -specify geckodriver path -specify browsertime path -precache cache shaders when WebRender is specified to avoid first-compile hit -option to restart adb between variants (workaround to adb file descriptor leak)
…un_test.py is now the main test
Author
|
FYI, I've updated this with all my changes (mitm support, etc). It's merged with your current main, and base tests work. lots of irrelevant stuff is in there; focus on run_test.py, desktop.sh, reload.sh, variants_fission.py, perf.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…run_test.py is now the main test