CLI-1790: Fix nullable deprecation in 1790,1791,1792.#1993
Open
deepakmishra2 wants to merge 4 commits into
Open
CLI-1790: Fix nullable deprecation in 1790,1791,1792.#1993deepakmishra2 wants to merge 4 commits into
deepakmishra2 wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Composer dependency constraints and the lockfile to address PHP deprecation warnings around implicitly nullable types (referenced in #1790/#1791/#1792), primarily by moving the project’s Symfony requirements to the 6.4 line and refreshing resolved package versions.
Changes:
- Bump direct
symfony/*requirements from^6.3to^6.4incomposer.json. - Regenerate
composer.lockto pull in newer Symfony patch releases and updated transitive dependencies.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| composer.json | Raises Symfony component constraints to ^6.4 to pick up newer compatible releases. |
| composer.lock | Refreshes locked dependency versions/hashes to match the updated constraints and newer releases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1993 +/- ##
=========================================
Coverage 92.42% 92.42%
Complexity 1957 1957
=========================================
Files 123 123
Lines 7091 7091
=========================================
Hits 6554 6554
Misses 537 537 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1993/acli.phar |
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
deepakmishra2
force-pushed
the
CLI-1790
branch
2 times, most recently
from
dc74ab2 to
daec65d
Compare
- Fix CodeStudioPipelinesMigrateCommandTest inputs to be explicit and deterministic instead of relying on ChoiceQuestion retry behavior. Data set #0 was failing in CI (ParaTest) because 'y' is invalid for ChoiceQuestion and with no remaining inputs an exception was thrown rather than falling back to the default value as in local sequential runs. - Fix AcsfAuthLoginCommandTest and ApiCommandTest to expect ValidatorException instead of MissingInputException, reflecting the current symfony/console behavior where ValidatorException propagates directly from question validators. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…t isolation issues With executionOrder=random, tests that set AH_CODEBASE_UUID only at the end of their method body could leave the env var set if they failed. The next test (e.g. ComposerScriptsListenerTest::testNoScripts) would then call determineCodebaseEnvironment(), which calls getCodebase(), and the mock HTTP client returns null, causing TypeError in CodebaseResponse::__construct(). - Add tearDown() to PullCommandTestBase to always unset AH_CODEBASE_UUID and call IdeHelper::unsetCloudIdeEnvVars() (preserving what the IdeRequiredTestTrait tearDown was doing before it was overridden) - Add AH_CODEBASE_UUID to WizardTestBase::getEnvVars() so it is also always cleaned up via tearDown Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
deepakmishra2
requested review from
anujkaushal,
Copilot,
shriacquia and
vishalkhode1
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
tests/phpunit/src/Commands/CodeStudio/CodeStudioPipelinesMigrateCommandTest.php:92
- This inputs list is likely misaligned with the command’s prompt order. After selecting the Cloud application, the next confirm prompt (outside IDE env) is to link the application to the repository, followed later by the confirm to create a new Code Studio project and one or more confirms for
${BLT_DIR}script migration. As written, the answers (y,y,0) are unlikely to match those prompts and can cause invalid-choice or “Not enough inputs” failures. Please update the inputs to match the actual prompt sequence (or explicitly disable interactivity for this test).
// No existing projects found - test project creation path.
[],
// Inputs.
[
// Would you like to search by git config?
'0',
// Select a Cloud Platform application:
'0',
// Would you like to link the Cloud application to this repository?
'y',
// Would you like to create a new Code Studio project?
'y',
// Choose which group this new project should belong to:
'0',
],
Comment on lines
62
to
70
| // One project. | ||
| [self::getMockedGitLabProject(self::$gitLabProjectId)], | ||
| // Inputs. | ||
| [ | ||
| // @todo | ||
| // Would you like to search by git config? | ||
| '0', | ||
| // Select a Cloud Platform application: | ||
| '0', | ||
| // Do you want to continue? | ||
| 'y', | ||
| ], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #1790, #1791, #1792