IDE-4857: Add PathRewriteConnector for environment based API path rewriting to make commands work with MEO.#1977
Open
vishalkhode1 wants to merge 3 commits intomainfrom
Open
IDE-4857: Add PathRewriteConnector for environment based API path rewriting to make commands work with MEO.#1977vishalkhode1 wants to merge 3 commits intomainfrom
PathRewriteConnector for environment based API path rewriting to make commands work with MEO.#1977vishalkhode1 wants to merge 3 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1977 +/- ##
============================================
+ Coverage 92.34% 92.37% +0.03%
- Complexity 1940 1953 +13
============================================
Files 122 123 +1
Lines 7051 7082 +31
============================================
+ Hits 6511 6542 +31
Misses 540 540 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1977/acli.phar |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a connector decorator to transparently rewrite specific Acquia Cloud API request paths when running in an MEO context (detected via AH_CODEBASE_UUID), and updates connector factory typing accordingly.
Changes:
- Added
PathRewriteConnectorto rewrite/applications/{uuid}/environmentsand/applications/{uuid}/permissionsrequests to codebase-based/translation/codebases/{codebaseUuid}/...endpoints. - Updated
ConnectorFactoryInterface(and implementations) to returnConnectorInterface. - Added PHPUnit coverage for the new connector and the factory behavior when
AH_CODEBASE_UUIDis set/unset.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/phpunit/src/CloudApi/PathRewriteConnectorTest.php | Adds unit tests validating rewrite behavior, passthrough behavior, and missing-env behavior. |
| tests/phpunit/src/CloudApi/ConnectorFactoryTest.php | Adds tests ensuring the factory wraps the connector when AH_CODEBASE_UUID is set. |
| src/ConnectorFactoryInterface.php | Simplifies the factory contract to return ConnectorInterface. |
| src/CloudApi/PathRewriteConnector.php | Introduces the connector decorator that performs regex-based path rewrites. |
| src/CloudApi/ConnectorFactory.php | Wraps the created connector with PathRewriteConnector when AH_CODEBASE_UUID is present; refactors connector construction into buildConnector(). |
| src/AcsfApi/AcsfConnectorFactory.php | Aligns the ACSF connector factory return type with the updated interface (ConnectorInterface). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vishalkhode1
changed the title
vishalkhode1
changed the title
PathRewriteConnector for environment based API path rewriting to make commands work with MEO.
vishalkhode1
changed the title
PathRewriteConnector for environment based API path rewriting to make commands work with MEO.PathRewriteConnector for environment based API path rewriting to make commands work with MEO.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TBD