[electrophysiology_browser] Fix typo which breaks timeSelection#10451
Open
jeffersoncasimir wants to merge 1 commit intoaces:28.0-releasefrom
Open
[electrophysiology_browser] Fix typo which breaks timeSelection#10451jeffersoncasimir wants to merge 1 commit intoaces:28.0-releasefrom
jeffersoncasimir wants to merge 1 commit intoaces:28.0-releasefrom
Conversation
jeffersoncasimir
added
Category: Bug
jeffersoncasimir
force-pushed
the
2026_04_17_fix_eeg_time_selection
branch
from
7bbe7da to
598f646
Compare
MaximeBICMTL
approved these changes
Apr 18, 2026
Contributor
There was a problem hiding this comment.
Wow, very fast PR, thanks! This fixes the issue for me 👍
@driusan would like this to also be ported to main whenever possible so I can update my local branches.
maximemulder
added
the
Difficulty: Trivial
Collaborator
|
@jeffersoncasimir I think this needs to be rebased to fix the tests? |
Contributor
|
@driusan this PR targets LORIS 28 since it is a bug fix and seems up-to-date for that branch, so nothing to rebase. Considering the tests fail for the PHP linter while this PR only touches Javascript the failure seems unrelated to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@MaximeBICMTL FYI