Skip to content

[elecrophysiology_browser] Fix session link keying in translated UI#10391

Merged
driusan merged 1 commit intoaces:mainfrom
arnav-makkar:fix/10388-eeg-browser-translation-bug
Mar 31, 2026
Merged

[elecrophysiology_browser] Fix session link keying in translated UI#10391
driusan merged 1 commit intoaces:mainfrom
arnav-makkar:fix/10388-eeg-browser-translation-bug

Conversation

@arnav-makkar
Copy link
Copy Markdown
Contributor

Brief summary of changes

  • Fixed EEG Browser session link generation to avoid /sessions/undefined in translated views.
  • Resolved session ID using the translated SessionID column key with fallback to row.SessionID.
Screen.Recording.2026-03-05.at.18.04.06.mov

Link(s) to related issue(s)

@github-actions github-actions Bot added Language: Javascript PR or issue that update Javascript code Module: electrophysiology_browser PR or issue related to electrophysiology_browser module labels Mar 5, 2026
Copy link
Copy Markdown
Contributor

@jeffersoncasimir jeffersoncasimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffersoncasimir jeffersoncasimir added the Passed manual tests PR has been successfully tested by at least one peer label Mar 30, 2026
@driusan driusan merged commit 81831b5 into aces:main Mar 31, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language: Javascript PR or issue that update Javascript code Module: electrophysiology_browser PR or issue related to electrophysiology_browser module Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[elecrophysiology_browser] Undefined session when missing translation

3 participants