Skip to content

Conversation

@arnav-makkar
Copy link
Contributor

Brief summary of changes

  • Fixed Child Component Processing: Updated FilterForm.js to correctly process child components that rely on defaultProps for their onUserInput callback.
  • Improved Reset Button Handling: The logic for identifying the "Reset" button has been simplified and hardened. It now explicitly targets any ButtonElement with type='reset' to ensure the clearFilter handler is attached, regardless of whether a custom callback was passed from the parent. This resolves issues where passing a bound function would prevent the clear logic from activating.
  • Added fallback logic for identifying component names (displayName vs name) to prevent potential errors with different component definitions.

Verification

Verified that clicking "Clear Filters" now clears all filter fields (text inputs and dropdowns) and removes query parameters from the URL.

Untitled

Link(s) to related issue(s)

@github-actions github-actions bot added the Language: Javascript PR or issue that update Javascript code label Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language: Javascript PR or issue that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[imaging_uploader] Clear filters is not working.

1 participant