[DQT] Improve "Query Loaded" dialog message and button text#10304
[DQT] Improve "Query Loaded" dialog message and button text#10304arnav-makkar wants to merge 4 commits intoaces:mainfrom
Conversation
github-actions
Bot
added
the
Module: dataquery
|
Great job. Syntax is excellent. LGTM |
| text: t('Successfully loaded query.', {ns: 'dataquery'}), | ||
| text: t('Return to the previous page to run or modify your query.', | ||
| {ns: 'dataquery'}), | ||
| confirmButtonText: t('Return', {ns: 'dataquery'}), |
There was a problem hiding this comment.
This doesn't seem to be in the .pot file or in any translations, so won't be translated.
| type: 'success', | ||
| title: t('Query Loaded', {ns: 'dataquery'}), | ||
| text: t('Successfully loaded query.', {ns: 'dataquery'}), | ||
| text: t('Return to the previous page to run or modify your query.', |
There was a problem hiding this comment.
This also isn't in any translations.
I find the wording more confusing than the previous wording. It sounds like an instruction to the user to press the back button on their browser.
There was a problem hiding this comment.
Yes I agree now that I'm taking a second look, this does add unnecessary cognitive overhead for the user. When I originally worked on this, I was just following the fix suggested in the issue and assumed that was the intended direction.
I can either close this PR and keep the the current message, or I could add the required translations.
What do you suggest?
There was a problem hiding this comment.
I'll see if anyone has any suggestions for the wording at tomorrow's weekly LORIS meeting.
3 participants
Brief summary of changes
Updates the "Query Loaded" success dialog to provide clearer navigation instructions to the user.
Link(s) to related issue(s)