Fix issue 11#36
Open
Marvinrose wants to merge 2 commits intoaccordproject:mainfrom
Open
Conversation
…roject#11 Signed-off-by: Chibuezem Marvinrose <rozzeymarvin32@gmail.com>
Signed-off-by: Chibuezem Marvinrose <rozzeymarvin32@gmail.com>
Member
|
Thanks for this contribution! Before we can review, please resolve the merge conflicts with the base branch. git fetch origin main
git rebase origin/main
# Resolve conflicts
git push --force-with-leaseOnce the conflicts are resolved, we'll proceed with the review. This comment was generated by AI on behalf of @mttrbrts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances
TemplateMarkInterpreter.checkTypesto detect unguarded optional properties at compile time, addressing the root cause of Issue #11.Changes:
Modified
checkTypesto flagVariableDefinitionnodes for optional properties.Added
issue-11.test.tswith a single test case using raw TemplateMark to verify the fix for an unguarded{{last}}in a template tied to a model with an optionallastproperty.