Add helper for coercing empty string query params to undefined#391
Merged
Conversation
…ty-string-params Coerce empty-string query params to undefined
|
@Johnpii1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description
Added a reusable helper coerceEmptyStringQueryParamsToUndefined in src/utils/empty-query-param.utils.ts that converts empty-string values to undefined, collapses empty-array results, and recurses into query record objects.
Applied the helper in the shared public query parser by normalizing the input in parsePublicQuery (src/utils/public-query-parse.utils.ts) before Zod validation so all public endpoints receive consistent query shapes.
Added unit tests in src/utils/empty-query-param.utils.test.ts that assert empty search, verified, and cursor params normalize the same as omitted values and that non-empty strings are preserved.
Testing
Testing
Ran the unit test suite for the new tests with pnpm exec jest src/utils/empty-query-param.utils.test.ts --runInBand, which passed.
Ran eslint on the modified files, which reported no errors (pnpm exec eslint src/utils/empty-query-param.utils.ts src/utils/empty-query-param.utils.test.ts src/utils/public-query-parse.utils.ts).
pnpm build was attempted but failed in this environment due to missing/generated Prisma client type exports unrelated to these changes (known workspace type generation issue).
pnpm lintpnpm buildpnpm exec prisma generatewhen schema or generated types changedChecklist
close #379