Standardize creator timestamp formatting#389
Merged
Chucks1093 merged 1 commit intoMay 31, 2026
Merged
Conversation
|
@utahkanz-ops Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatIsoTimestamphelper that normalizes timestamp inputs to a single UTC ISO 8601 representation with milliseconds. Creator list items and creator detail responses now use the helper forcreatedAtandupdatedAt, so clients receive consistently formatted timestamp strings across those response paths.Issue
Changes
src/utils/iso-timestamp.utils.tswith validation for invalid timestamp values.createdAtandupdatedAtin the creator list projection and mapped them through the new helper inmapCreatorListItem.createdAtandupdatedAtto creator detail response schema and formatted database values through the helper.createdAt: nullandupdatedAt: nullwhen no database row exists.Validation
pnpm.cmd exec jest src/utils/iso-timestamp.utils.test.ts src/modules/creators/creator-list-item.mapper.test.ts --runInBandpassed.pnpm.cmd lintpassed.pnpm.cmd buildwas run and now only fails on generated Prisma Client exports missing from@prisma/client(Prisma,PrismaClient,StellarWallet,User). This matches the local environment issue where Prisma Client generation is unavailable/stale, not the timestamp changes.Notes
InsightArenafork URL does not matchaccesslayerorg/accesslayer-server; this work used the existing verified local checkout with originutahkanz-ops/accesslayer-serverand upstreamaccesslayerorg/accesslayer-server.pnpm-lock.yamlwas not modified.