Log unexpected null creator field#388
Merged
Chucks1093 merged 1 commit intoMay 31, 2026
Merged
Conversation
|
@utahkanz-ops Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
displayName, a non-nullableCreatorProfileschema field, is unexpectedly returned asnullfrom the database. The mapper still returns the same public response shape as before, so the null case continues to serialize asname: nullfor clients while giving maintainers visibility into the data integrity problem.Issue
Changes
displayNamefield during creator list item mapping.fieldName,creatorId, andrequestIdin the warning payload.Validation
pnpm.cmd exec jest src/modules/creators/creator-list-item.mapper.test.ts --runInBandpassed.pnpm.cmd lintpassed.pnpm.cmd buildwas run but did not complete successfully because Prisma Client was not generated in this Windows environment after pnpm blocked dependency build scripts.pnpm.cmd exec prisma generateandpnpm.cmd exec prisma --versionboth timed out before producing output, so the build failure appears environment/tooling-related rather than caused by this mapper change.Notes
pnpm-lock.yamlwas not modified.