Issue 349 event payload builder#374
Merged
Chucks1093 merged 8 commits intoMay 30, 2026
Merged
Conversation
- Implement CreatorRegisteredEventBuilder for building expected CreatorRegisteredEvent payloads - Implement BuyEventPayloadBuilder for building expected buy event tuples - Update test_register_creator_event_data_is_indexer_friendly to use CreatorRegisteredEventBuilder - Update test_buy_key_event_payload_fields_are_validated_from_fixture to use BuyEventPayloadBuilder - Improves test readability and makes assertions easier to update when schema changes Resolves accesslayerorg#349
|
@T-kesh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #349
This PR introduces fluent builder helpers for constructing expected event payloads in test assertions, resolving #349. The
CreatorRegisteredEventBuilderandBuyEventPayloadBuilderstructs replace inline field construction with chainable, named-parameter methods, making test assertions more readable and significantly easier to maintain when event schemas change. The builders are applied to two existing test cases (test_register_creator_event_data_is_indexer_friendlyandtest_buy_key_event_payload_fields_are_validated_from_fixture), demonstrating how the approach scales across the test suite while keeping the test module implementation self-contained.