test: add sell protocol fee recipient balance regression#340
Merged
Conversation
Credit protocol fees to recipient balance on sell and assert the increase matches the bps-derived fee amount. Closes accesslayerorg#296
|
@wheval Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a regression test that verifies the protocol fee recipient balance increases by the correct amount after a sell, and wires sell execution to accrue that balance.
Purpose / Motivation
Sell event and quote tests confirm fee fields are computed, but they do not prove the protocol fee recipient actually receives the fee. A direct balance assertion closes that gap and guards against regressions where fees are calculated but not credited.
Changes Made
sell_keyusing the current fee config and key priceget_protocol_recipient_balanceread method for test and indexer visibilityHow to Test
cargo test --test sell_protocol_fee_recipient_balance.test_sell_increases_protocol_fee_recipient_balance_by_bps_feetest_sell_protocol_fee_recipient_balance_accumulates_across_two_sellscargo test --workspaceto confirm no regressions in existing sell and fee tests.Expected: protocol fee recipient balance is
0before the first sell and increases byfloor(price * protocol_bps / 10_000)after each sell.Breaking Changes
sell_keynow accrues the protocol fee share toget_protocol_recipient_balance.Related Issues
Closes #296
Checklist