test: add sell quote vs execution proceeds regression#338
Merged
Conversation
Assert get_sell_quote total_amount matches execution-path net proceeds at supply levels 1 and 5 before and after sell_key. Closes accesslayerorg#304
|
@wheval Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a regression test that calls
get_sell_quotebeforesell_keyand asserts the quoted seller net (total_amount) exactly matches proceeds derived from the execution fee path, with zero divergence.Purpose / Motivation
Sell quotes and sell execution use separate code paths. A mismatch between the quoted payout and the fees applied at execution would break client trust and can cause financial discrepancies. This test closes that gap by verifying both paths agree for the same
(creator, holder)inputs.Changes Made
creator-keys/tests/sell_quote_matches_execution.rsquote.total_amountequals execution-path net proceeds (price - fees) before and aftersell_keyHow to Test
cargo test -p creator-keys --test sell_quote_matches_executiontest_sell_quote_proceeds_match_execution_at_supply_oneandtest_sell_quote_proceeds_match_execution_at_supply_fivepasscargo test -p creator-keysScreenshots (if applicable)
N/A — contract tests only.
Breaking Changes
Related Issues
Closes #304
Checklist