proof of concept: design system integration#380
Draft
YellowKirby wants to merge 2 commits intoaccessiblecommunity:mainfrom
Draft
proof of concept: design system integration#380YellowKirby wants to merge 2 commits intoaccessiblecommunity:mainfrom
YellowKirby wants to merge 2 commits intoaccessiblecommunity:mainfrom
Conversation
for now, this is just a dependency directly on the git repo, but ideally we publish the design-system project as a (versioned!) package instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Don't merge me! it's definitely not functioning or ready yet :)
A very early proof-of-concept integrating the website with the upcoming design system (DS) work. I plan on pushing more and evolving this branch as we figure out more of the DS exports and packaging.
What works
npmdependency to the DS repoWhat doesn't
tint-color()can NOT be used. This might be a bit of an early integration pain point, but I don't think it's a long-term issue. We'd ideally rely entirely on DS variables and not need to do any sass math