Possible fix for issues with initial_prompt#151
Merged
absadiki merged 2 commits intoabsadiki:mainfrom Dec 30, 2025
Merged
Conversation
…n Framework laptop with and without Vulkan support
absadiki
requested changes
Dec 25, 2025
src/main.cpp
Outdated
| return whisper_ctx_init_openvino_encoder(ctx->ptr, model_path, device, cache_dir); | ||
| } | ||
|
|
||
| /* |
Owner
There was a problem hiding this comment.
Thanks a lot @dlparker for the PR, really appreciate it. All CI checks seems to be passing without any issues.
Could you please just go ahead and remove the old code that’s currently commented out and keep only the new implementation? Once that’s cleaned up, I’ll go ahead and merge it.
Removed commented-out class definition for WhisperFullParamsWrapper.
Contributor
Author
|
I have made the requested change, @absadiki |
Owner
|
Sounds great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied change to copy constructor suggested by absadiki and tested on Framework laptop with and without Vulkan support.