Skip to content

Support K8s Pod affinity configuration for Pod scheduling #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThoSap merged 3 commits into from
Jan 29, 2026
Merged

Support K8s Pod affinity configuration for Pod scheduling #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d792e9
support K8s Pod affinity configuration for Pod scheduling
ThoSap Jan 29, 2026
37c3aa9
also add the LICENSE notice to the generated Helm chart
ThoSap Jan 29, 2026
a57be6f
fix company name in file LICENSE
ThoSap Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Copyright About Bits GmbH
Copyright AboutBits GmbH

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

Expand Down
7 changes: 7 additions & 0 deletions operator/src/main/helm/LICENSE
View file
Open in desktop
Copy link
Member

@alexlanz alexlanz Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked already about the license in another PR. What type of license is this? And why is not our general license enough on the project?

Copy link
Contributor Author

@ThoSap ThoSap Jan 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidentally committed the LICENSE file on the other PR branch and reverted it again.

As mentioned in my other comment #13 (comment), the LICENSE file is MIT and has been added to this folder, as the Quarkus Helm extension will package it with the automatically built *.tgz Helm chart archive.

I wanted the LICENSE to be also present there.

I copied it from https://github.com/aboutbits/react-ui/blob/main/license.md

All our projects are MIT.

Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Copyright AboutBits GmbH

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
9 changes: 9 additions & 0 deletions operator/src/main/kubernetes/kubernetes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
apiVersion: apps/v1
kind: Deployment
metadata:
name: postgresql-operator
spec:
template:
spec:
affinity: {}
9 changes: 9 additions & 0 deletions operator/src/main/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,12 @@ quarkus:
value: ${quarkus.kubernetes.image-pull-secrets[0]}
paths:
- (kind == Deployment).spec.template.spec.imagePullSecrets[0].name
description: Kubernetes image pull secret to use if the OCI image is hosted on a private registry
affinity:
property: affinity
value-as-map: {}
path: (kind == Deployment).spec.template.spec.affinity
description: Kubernetes affinity configuration for Pod scheduling
expressions:
release-name-labels:
expression: "{{ .Release.Name }}"
Expand All @@ -116,6 +122,9 @@ quarkus:
release-name-deployment-labels:
expression: "{{ .Release.Name }}"
path: (kind == Deployment).spec.template.metadata.labels.'app.kubernetes.io/name'
affinity:
expression: "{{- toYaml (.Values.app.affinity | default dict) | nindent 8 }}"
path: (kind == Deployment).spec.template.spec.affinity
Comment on lines +125 to +127
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The affinity configuration is defined twice: once as a property (lines 107-111) and once as an expression (lines 125-127). This duplication could lead to confusion about which configuration takes precedence or how they interact. Consider documenting the relationship between these two definitions or consolidating them if they serve the same purpose.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@ThoSap ThoSap Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need both, one for the default value and description in the generated README.md, the other for the newline and indentation of the affinity block.

https://docs.quarkiverse.io/quarkus-helm/dev/

kubernetes:
name: postgresql-operator
version: ${quarkus.application.version}
Expand Down