Skip to content

fix(push): use onNewRegistrationToken instead of activate() on FCM token refresh #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maratal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(push): use onNewRegistrationToken instead of activate() on FCM token refresh #3282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/pages/docs/push/getting-started/fcm.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ import android.util.Log
import androidx.core.app.NotificationCompat
import com.google.firebase.messaging.FirebaseMessagingService
import com.google.firebase.messaging.RemoteMessage
import io.ably.lib.types.RegistrationToken

class PushNotificationService : FirebaseMessagingService() {

Expand All @@ -180,9 +181,9 @@ class PushNotificationService : FirebaseMessagingService() {
override fun onNewToken(token: String) {
super.onNewToken(token)
Log.d(TAG, "New FCM token received")
// Re-activate push with Ably whenever the FCM token is refreshed
try {
AblyHelper.getInstance().push.activate()
// Update the FCM token on Ably server
AblyHelper.getInstance().push.getActivationContext().onNewRegistrationToken(RegistrationToken.Type.FCM, token)
} catch (e: Exception) {
Log.e(TAG, "Error updating FCM token with Ably", e)
}
Expand Down
Loading