Conversation
Added aria-busy={isLoading ? 'true' : undefined} to the global Button component to correctly indicate busy state to screen readers during asynchronous operations.
Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Added aria-busy={isLoading ? 'true' : undefined} to the global Button component to correctly indicate busy state to screen readers during asynchronous operations. Also fixed CI warnings/errors in EventAnnotations and check-models.
Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
Fixed a division by zero error in arimaSurrogateForecast that caused NaN MAPEs in CI, breaking the forecast backtests. Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
Added aria-busy attribute to the global Button component and EventAnnotations inline buttons to correctly indicate busy state to screen readers during asynchronous operations. Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
1 participant
💡 What: Added the
aria-busyattribute to the sharedButtoncomponent whenisLoadingis true.🎯 Why: To inform screen readers that the element is currently busy processing an action.
📸 Before/After: Visuals remain unchanged; DOM inspection confirms the attribute is correctly toggled.
♿ Accessibility: Screen readers will now announce the busy state to visually impaired users, improving the overall accessibility of the application.
PR created automatically by Jules for task 14058529436733396101 started by @aarjava