Skip to content

Please consider the following formatting changes to #14185 #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aalkin merged 1 commit into from
Apr 16, 2025
Merged

Please consider the following formatting changes to #14185 #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Framework/Core/include/Framework/Expressions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ struct ParameterNode : LiteralNode {
struct ConditionalNode {
};


/// concepts
template <typename T>
concept is_literal_like = std::same_as<T, LiteralNode> || std::same_as<T, PlaceholderNode> || std::same_as<T, ParameterNode>;
Expand Down
4 changes: 2 additions & 2 deletions Framework/Core/src/Expressions.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ Operations createOperations(Filter const& expression)

auto processLeaf = [](Node const* const node) {
return std::visit(
[](auto const& n){return makeDatum(n);},
[](auto const& n) { return makeDatum(n); },
node->self);
};

Expand All @@ -261,7 +261,7 @@ Operations createOperations(Filter const& expression)
// create operation spec, pop the node and add its children
auto operationSpec =
std::visit(
[&](auto const& n){ return makeOp(n, top.node_ptr->index); },
[&](auto const& n) { return makeOp(n, top.node_ptr->index); },
top.node_ptr->self);

operationSpec.result = DatumSpec{top.index, operationSpec.type};
Expand Down