Skip to content

fix: add exclude_list to @trace_class on high-frequency event classes #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
naveenkumarbaskaran wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −4
Open

fix: add exclude_list to @trace_class on high-frequency event classes #1041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/a2a/server/events/event_consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@
logger = logging.getLogger(__name__)


@trace_class(kind=SpanKind.SERVER)
@trace_class(
kind=SpanKind.SERVER,
exclude_list=['consume_all'],
)
class EventConsumer:
"""Consumer to read events from the agent event queue."""

Expand Down
5 changes: 4 additions & 1 deletion src/a2a/server/events/event_queue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,10 @@ async def enqueue_event(self, event: Event) -> None:
"""


@trace_class(kind=SpanKind.SERVER)
@trace_class(
kind=SpanKind.SERVER,
exclude_list=['enqueue_event', 'dequeue_event', 'task_done', 'is_closed'],
)
class EventQueueLegacy(EventQueue):
"""Event queue for A2A responses from agent.

Expand Down
5 changes: 4 additions & 1 deletion src/a2a/server/events/event_queue_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@
logger = logging.getLogger(__name__)


@trace_class(kind=SpanKind.SERVER)
@trace_class(
kind=SpanKind.SERVER,
exclude_list=['enqueue_event', 'dequeue_event', 'task_done', 'is_closed'],
)
class EventQueueSource(EventQueue):
"""The Parent EventQueue.

Expand Down
5 changes: 4 additions & 1 deletion src/a2a/server/events/in_memory_queue_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@
from a2a.utils.telemetry import SpanKind, trace_class


@trace_class(kind=SpanKind.SERVER)
@trace_class(
kind=SpanKind.SERVER,
exclude_list=['add', 'get', 'create_or_tap'],
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

The tap method is missing from the exclude_list. To be consistent with the exclusion of add, get, and create_or_tap, and to reduce redundant spans for management operations that are already covered by the underlying queue's traces, tap should also be excluded.

Suggested change
exclude_list=['add', 'get', 'create_or_tap'],
exclude_list=['add', 'get', 'tap', 'create_or_tap'],

)
class InMemoryQueueManager(QueueManager):
"""InMemoryQueueManager is used for a single binary management.

Expand Down
Loading