Add support for Zune HD#14
Open
spidersandmoths wants to merge 7 commits into
Open
Conversation
Add windows PowerShell variants of the existing linux scripts
Adds needed headers, fixes issues with xml, and adds support for Zune HD artist images.
yoshiask
requested changes
May 14, 2026
Contributor
yoshiask
left a comment
yoshiask
left a comment
There was a problem hiding this comment.
Nice work, thank you! Just a few questions and nitpicks
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="SixLabors.ImageSharp" Version="3.1.11" /> |
Contributor
There was a problem hiding this comment.
Nit: Isn't this already pulled in as a transient dependency of Zune.Net.Shared?
Author
There was a problem hiding this comment.
Apologies, forgot to take that out when merging. It should no longer be needed.
| public class Artist : Entry | ||
| { | ||
| [XmlElement("sortTitle")] | ||
| public string SortTitle { get; set; } |
Contributor
There was a problem hiding this comment.
If SortTitle isn't the correct name and isn't used in older API versions, let's remove it
| { | ||
| return await LastFM.GetSimilarArtistsByMBID(mbid); | ||
| var relatedArtists = await LastFM.GetSimilarArtist(mbid); | ||
| var feed = LastFM.CreateFeed<Artist>($"/artist/{mbid}/similarArtists", "Similar"); |
Contributor
There was a problem hiding this comment.
Can the path here be pulled from Request.Path.Value like the Details endpoint?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes artist images, related artist, and bio in support for the Zune HD. This should provide close to full functionality for the device in terms of artist and marketplace data.