Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
128 changes: 128 additions & 0 deletions .github/pull_request_template_v2.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,128 @@
# Context

### Spec PR
Comment thread
muhammad-ali-e marked this conversation as resolved.
<!-- Link to the merged spec repo PR that authorizes this work. This PR is blocked until the spec PR is merged. -->
Zipstack/unstract-review-context#____

### Summary
<!-- One paragraph describing what this implementation delivers. -->

### Implementation Ticket
<!-- Link to the originating Jira ticket. -->

---

# Implementation Plan

## Exit Criteria (Definition of Done)
<!-- What conditions must be true for this PR to be considered complete? -->

- [ ] All CI checks pass
- [ ] Acceptance criteria from spec PR verified
- [ ] Documentation updated (if applicable)
- [ ] No regressions introduced

## Implementation Constraints
<!-- Are there any constraint exceptions being requested? If none, state "No exceptions requested." -->

## Sequencing & Dependencies
<!-- Which PRs or branches must merge before this? Which PRs does this block? -->

- Depends on: #____
- Blocks: #____

## Verification Plan
<!-- How is the correctness of this implementation validated? -->

- [ ] Unit tests added/updated
- [ ] Integration tests covering: ...
- [ ] Performance tests (if applicable): ...
- [ ] Manual verification steps: ...

## Rollout Strategy
<!-- How does this change reach production safely? -->

- [ ] Feature flag: `flag_name`
- [ ] Migration required: [ ] reversible [ ] irreversible
- [ ] Canary / staged rollout plan: ...
- [ ] Monitoring / alerting in place for: ...

---

# Testing Evidence

## Test Results
<!-- Paste or link CI output, coverage reports, or manual test evidence. -->

## Risk Assessment
<!-- What could go wrong with this change? How is that risk mitigated? -->

| Risk | Likelihood | Impact | Mitigation |
|------|------------|--------|------------|
| | | | |

---

<!-- ================================================================== -->
<!-- BELOW THIS LINE IS AGENT-GENERATED. DO NOT EDIT. -->
<!-- The reviewer agent compiles this section automatically by -->
<!-- cross-checking the PR diff against Spec Compliance artifacts in -->
<!-- the spec repo (unstract-review-context). -->
<!-- ================================================================== -->

# Spec Compliance Report

## Verdict
<!-- PASS / CONFLICT DETECTED — escalated to @org/architects -->

## Spec PR Linkage
<!-- Verified: spec PR merged / Missing / Mismatched -->

## Compliance Checks

### Product Requirements

#### Acceptance Criteria
<!-- Does the implementation satisfy the defined business behavior? -->

#### Scope Definition
<!-- Does the implementation stay within defined scope boundaries? -->

#### Non-Functional Requirements
<!-- Does the code meet performance, availability, and resource contracts? -->

#### Dependencies
<!-- Are all dependencies used in this PR present in the approved registry? -->

#### Assumptions & Constraints
<!-- Does the code violate any active assumptions or constraints? -->

### Specification

#### Architecture Decision Records (ADRs)
<!-- Does the code conform to active architectural decisions? -->

#### API / Interface Contracts
<!-- Do request/response schemas match the approved contracts? -->

#### Data Model & State Ownership
<!-- Does the code respect entity ownership and state transition rules? -->

#### Failure Modes & Resilience
<!-- Are required resilience patterns (retries, timeouts, circuit breakers) present? -->

#### Security Considerations
<!-- Are trust boundaries, auth mechanisms, and privilege models respected? -->

#### Implementation Constraints
<!-- Does the code avoid forbidden patterns and follow required patterns? -->

## Conflicts (if any)

| # | Artifact | File:Line | Violation | Severity |
|---|----------|-----------|-----------|----------|
| | | | | |

## Recommendation
<!-- Resolve conflicts before re-requesting review. If any conflict requires -->
<!-- amending a Spec artifact, raise a new spec PR first. -->