[FIX] Adding prompt files to the build for Agentic prompt Studio#1853
[FIX] Adding prompt files to the build for Agentic prompt Studio#1853gaya3-zipstack merged 2 commits intomainfrom
Conversation
Signed-off-by: harini-venkataraman <115449948+harini-venkataraman@users.noreply.github.com>
for more information, see https://pre-commit.ci
Summary by CodeRabbit
WalkthroughA dockerignore file is updated to add an inclusion exception for system prompt markdown files, preventing them from being ignored during Docker image builds. The change adds a whitelist pattern after existing Markdown exclusion rules. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan for PR comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR adds a single Key observations:
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["Docker build context"] -->|"Rule: *.md (line 47)"| B["Exclude ALL .md files"]
B -->|"Rule: !README.md (line 48)"| C["Re-include README.md"]
C -->|"Rule: !*_system_prompt.md (line 50) ← NEW"| D["Re-include *_system_prompt.md files"]
D -->|"Rule: !prompt-service (line 60)"| E["Re-include all of prompt-service/"]
E --> F["Final image contains prompt files"]
G["*_system_prompt.md in prompt-service/plugins/*/"] -->|"Matched by *.md → excluded"| H["Excluded by *.md"]
H -->|"Matched by !*_system_prompt.md → included"| I["Re-included by new rule"]
I -->|"Matched by !prompt-service → included"| F
Last reviewed commit: 2cac4d8 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docker/dockerfiles/prompt.Dockerfile.dockerignore`:
- Around line 47-50: The .dockerignore exception rule "!*_system_prompt.md" is
ineffective because no files match that pattern; either delete the exception
line entirely or replace it with the correct recursive pattern for the intended
filenames (for example use a double-star pattern like "!**/*_system_prompt.md"
or correct the basename to the actual filenames used), and ensure any updated
pattern matches the actual prompt file naming convention referenced elsewhere in
the repo (search for "_system_prompt.md" or the agent prompt filename to confirm
the exact name).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7e312130-cd15-4129-978c-304e346eb0f9
📒 Files selected for processing (1)
docker/dockerfiles/prompt.Dockerfile.dockerignore
|



What
Add
.dockerignorerule to include*_system_prompt.mdfiles in Docker builds while excluding all other markdown files.Why
The agentic extraction plugin agents load system prompt templates from
*_system_prompt.mdfiles at runtime. These files are excluded when*.mdis in.dockerignore, causing the agent pipeline to fail with missing prompt errors in containerized deployments.How
Add
!*_system_prompt.mdexception to.dockerignoreso these prompt template files are copied into the Docker image.Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
No. This only adds previously-excluded files into the Docker image. No existing behavior changes — the prompt files were always needed, just missing from the build context.
Database Migrations
None.
Env Config
None.
Relevant Docs
N/A
Related Issues or PRs
N/A
Dependencies Versions
N/A
Notes on Testing
*_system_prompt.mdfiles are present inside the container.Screenshots
N/A
Checklist
I have read and understood the Contribution Guidelines.