Open
Conversation
The priority ordered ready task queue used previously had O(n) complexity for insertions, but when using at most 32 priorities you can optimize this down to O(1) by using one bucket (list) per priority.
Grazfather
approved these changes
Feb 8, 2026
| pub const highest: @This() = @enumFromInt(std.math.maxInt(@typeInfo(@This()).@"enum".tag_type)); | ||
|
|
||
| pub fn next_higher(prio: Priority) Priority { | ||
| return @enumFromInt(@intFromEnum(prio) +| 1); |
Collaborator
There was a problem hiding this comment.
is this supposed to wrap around? that is the +| for?
Collaborator
Author
There was a problem hiding this comment.
+| is saturating add which means the addition will "saturate" at the max int value before the overflow. This function isn't used anymore so I'll just remove it.
| \\mret | ||
| : | ||
| : [schedule_in_isr] "i" (&schedule_in_isr), | ||
| : [tick_handler] "i" (&tick_handler), |
Collaborator
There was a problem hiding this comment.
Do we not need all the clobbers? Is this because it's an interrupt handler?
Collaborator
Author
There was a problem hiding this comment.
Since it is a naked function, I don't think clobbers would make any difference since the compiler has nowhere to save/restore those registers.
mattnite
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some numbers with 200 concurrent tasks:
I also added support for time slicing (switch between tasks of the same priority on the tick interval). This is by default off.
Tasks can now be awaited and the memory freed. I used this to implement cleanup for radio/timer.zig, but for the tasks spawned by the wifi driver it is more complicated so I will leave this for a later PR.
Unit tests for the esp port now run on CI.