Skip to content

fix(mister): launch 3DO CHD with correct MGL slot #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wizzomafizzo merged 2 commits into from
May 25, 2026
+41 −3
Merged

fix(mister): launch 3DO CHD with correct MGL slot #844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83f52fe
fix(mister): launch 3DO CHD with correct MGL slot
wizzomafizzo May 25, 2026
61ee879
style(mister): fix 3DO CHD test lint
wizzomafizzo May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/platforms/mister/cores/cores.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,11 @@ var Systems = map[string]Core{
RBF: "_Console/3DO",
Slots: []Slot{
{
Exts: []string{".iso", ".cue"},
Exts: []string{".iso", ".cue", ".chd"},
Mgl: &MGLParams{
Delay: 1,
Method: "s",
Index: 1,
Index: 0,
},
},
},
Expand Down
10 changes: 10 additions & 0 deletions pkg/platforms/mister/cores/cores_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,16 @@ func TestPathToMGLDef(t *testing.T) {
path: "goldeneye.z64",
wantMgl: Systems["Nintendo64"].Slots[0].Mgl,
},
{
name: "3DO CHD disk slot",
systemID: "3DO",
path: "Need for Speed.chd",
wantMgl: &MGLParams{
Delay: 1,
Method: "s",
Index: 0,
},
},
{
name: "Nil MGL allowed (Arcade .mra)",
systemID: "Arcade",
Expand Down
30 changes: 29 additions & 1 deletion pkg/platforms/mister/mgls/mgls_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,13 +263,41 @@ func TestGenerateMgl(t *testing.T) {
},
},
},
path: "/media/fat/games/Saturn/America/NiGHTS into Dreams... (USA, Brazil).chd",
path: filepath.Join(
string(filepath.Separator),
"media", "fat", "games", "Saturn", "America", "NiGHTS into Dreams... (USA, Brazil).chd",
),
want: "<mistergamedescription>\n\t<rbf>_Console/Saturn</rbf>\n" +
"\t<file delay=\"2\" type=\"s\" index=\"0\" " +
"path=\"../../../../../media/fat/games/Saturn/America/" +
"NiGHTS into Dreams... (USA, Brazil).chd\"/>\n" +
"</mistergamedescription>",
},
{
name: "3DO CHD uses disk slot zero",
core: &cores.Core{
ID: "3DO",
RBF: "_Console/3DO",
Slots: []cores.Slot{
{
Exts: []string{".iso", ".cue", ".chd"},
Mgl: &cores.MGLParams{
Delay: 1,
Method: "s",
Index: 0,
},
},
},
},
path: filepath.Join(
string(filepath.Separator),
"media", "fat", "games", "3DO", "The Need for Speed.chd",
),
want: "<mistergamedescription>\n\t<rbf>_Console/3DO</rbf>\n" +
"\t<file delay=\"1\" type=\"s\" index=\"0\" " +
"path=\"../../../../../media/fat/games/3DO/The Need for Speed.chd\"/>\n" +
"</mistergamedescription>",
},
{
name: "path with XML-reserved characters is escaped",
core: &cores.Core{
Expand Down
Loading