REST service: Logging, Error Handling and Authentication and Authorization#3
Open
YuliaDemir wants to merge 32 commits into
Open
REST service: Logging, Error Handling and Authentication and Authorization#3YuliaDemir wants to merge 32 commits into
YuliaDemir wants to merge 32 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3. deadline 15.06.2025/ 17.06.2025
4. score 290/340
Logging & Error Handling:
+20 Custom LoggingService is implemented and used for logging
+20 Custom Exception Filter is implemented and used for handling exceptions during request processing
+20 Logging for request (of at least url, query parameters, body) and response with status code is implemented.
+20 Error handling is implemented including sending response with an appropriate http status code and errors logging.
+10 Error handling and logging is implemented for uncaughtException event.
+10 Error handling and logging is implemented for unhandledRejection event.
Authentication and Authorization:
+30 Route /auth/signup implemented correctly, related logic is divided between controller and corresponding service
+30 Route /auth/login has been implemented, related logic is divided between controller and corresponding service
+10 User password saved into database as hash
+20 Access Token is implemented,JWT payload contains userId and login, secret key is saved in .env.
+40 Authentication is required for the access to all routes except /auth/signup, /auth/login, /doc and /
+10 Separate module is implemented within application scope to check that all requests to all routes except mentioned above contain required JWT token
Advanced:
+20 Logs are written to a file.
+30 Route /auth/refresh implemented correctly, related logic is divided between controller and corresponding service
Penalties:
-10 for one test