Skip to content

Relax Guava dependency version constraint to allow major version 33 #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
emlun merged 1 commit into from
Jan 19, 2026
Merged

Relax Guava dependency version constraint to allow major version 33 #449

emlun merged 1 commit into from
Jan 19, 2026

Conversation

@emlun
Copy link
Member

@emlun emlun commented Jan 19, 2026

Fixes #448.

Before:

$ ./gradlew :webauthn-server-core:dependencies :webauthn-server-attestation:dependencies :yubico-util:dependencies | grep guava
|    +--- com.google.guava:guava:[24.1.1,33) -> 32.1.3-jre (c)
+--- com.google.guava:guava -> 32.1.3-jre
|    +--- com.google.guava:failureaccess:1.0.1
|    +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
+--- com.google.guava:guava (n)
+--- com.google.guava:guava FAILED
+--- com.google.guava:guava FAILED
|    +--- com.google.guava:guava:[24.1.1,33) -> 32.1.3-jre (c)
+--- com.google.guava:guava -> 32.1.3-jre
|    +--- com.google.guava:failureaccess:1.0.1
|    +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
|    +--- com.google.guava:guava:[24.1.1,33) -> 32.1.3-jre (c)
+--- com.google.guava:guava -> 32.1.3-jre
|    +--- com.google.guava:failureaccess:1.0.1
|    +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
|    +--- com.google.guava:guava:[24.1.1,33) -> 32.1.3-jre (c)
+--- com.google.guava:guava -> 32.1.3-jre
|    +--- com.google.guava:failureaccess:1.0.1
|    +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
|    +--- com.google.guava:guava:[24.1.1,33) -> 32.1.3-jre (c)
+--- com.google.guava:guava -> 32.1.3-jre
|    +--- com.google.guava:failureaccess:1.0.1
|    +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
|    |    +--- com.google.guava:guava:14.0.1 -> 32.1.3-jre (*)
|    +--- com.google.guava:guava:14.0.1 -> 32.1.3-jre (*)
|    |    \--- com.google.guava:guava:14.0.1 -> 32.1.3-jre (*)
|    +--- com.google.guava:guava:[24.1.1,33) -> 32.1.3-jre (c)
+--- com.google.guava:guava -> 32.1.3-jre
|    +--- com.google.guava:failureaccess:1.0.1
|    +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
|    |    +--- com.google.guava:guava:14.0.1 -> 32.1.3-jre (*)
|    +--- com.google.guava:guava:14.0.1 -> 32.1.3-jre (*)
|    |    \--- com.google.guava:guava:14.0.1 -> 32.1.3-jre (*)
|    +--- com.google.guava:guava:[24.1.1,33) -> 32.1.3-jre (c)
|    +--- com.google.guava:guava -> 32.1.3-jre
|    |    +--- com.google.guava:failureaccess:1.0.1
|    |    +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
     |    +--- com.google.guava:guava:14.0.1 -> 32.1.3-jre (*)
     +--- com.google.guava:guava:14.0.1 -> 32.1.3-jre (*)
     |    \--- com.google.guava:guava:14.0.1 -> 32.1.3-jre (*)
|    +--- com.google.guava:guava:[24.1.1,33) -> 32.1.3-jre (c)
|    +--- com.google.guava:guava -> 32.1.3-jre
|    |    +--- com.google.guava:failureaccess:1.0.1
|    |    +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
|    +--- com.google.guava:guava:[24.1.1,33) -> 32.1.3-jre (c)
|    +--- com.google.guava:guava -> 32.1.3-jre
|    |    +--- com.google.guava:failureaccess:1.0.1
|    |    +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
     |    +--- com.google.guava:guava:14.0.1 -> 32.1.3-jre (*)
     +--- com.google.guava:guava:14.0.1 -> 32.1.3-jre (*)
     |    \--- com.google.guava:guava:14.0.1 -> 32.1.3-jre (*)

After:

$ ./gradlew :webauthn-server-core:dependencies :webauthn-server-attestation:dependencies :yubico-util:dependencies | grep guava
|    +--- com.google.guava:guava:[24.1.1,34) -> 33.5.0-jre (c)
+--- com.google.guava:guava -> 33.5.0-jre
|    +--- com.google.guava:failureaccess:1.0.3
|    +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
+--- com.google.guava:guava (n)
+--- com.google.guava:guava FAILED
+--- com.google.guava:guava FAILED
|    +--- com.google.guava:guava:[24.1.1,34) -> 33.5.0-jre (c)
+--- com.google.guava:guava -> 33.5.0-jre
|    +--- com.google.guava:failureaccess:1.0.3
|    +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
|    +--- com.google.guava:guava:[24.1.1,34) -> 33.5.0-jre (c)
+--- com.google.guava:guava -> 33.5.0-jre
|    +--- com.google.guava:failureaccess:1.0.3
|    +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
|    +--- com.google.guava:guava:[24.1.1,34) -> 33.5.0-jre (c)
+--- com.google.guava:guava -> 33.5.0-jre
|    +--- com.google.guava:failureaccess:1.0.3
|    +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
|    +--- com.google.guava:guava:[24.1.1,34) -> 33.5.0-jre (c)
+--- com.google.guava:guava -> 33.5.0-jre
|    +--- com.google.guava:failureaccess:1.0.3
|    +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
|    |    +--- com.google.guava:guava:14.0.1 -> 33.5.0-jre (*)
|    +--- com.google.guava:guava:14.0.1 -> 33.5.0-jre (*)
|    |    \--- com.google.guava:guava:14.0.1 -> 33.5.0-jre (*)
|    +--- com.google.guava:guava:[24.1.1,34) -> 33.5.0-jre (c)
+--- com.google.guava:guava -> 33.5.0-jre
|    +--- com.google.guava:failureaccess:1.0.3
|    +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
|    |    +--- com.google.guava:guava:14.0.1 -> 33.5.0-jre (*)
|    +--- com.google.guava:guava:14.0.1 -> 33.5.0-jre (*)
|    |    \--- com.google.guava:guava:14.0.1 -> 33.5.0-jre (*)
|    +--- com.google.guava:guava:[24.1.1,34) -> 33.5.0-jre (c)
|    +--- com.google.guava:guava -> 33.5.0-jre
|    |    +--- com.google.guava:failureaccess:1.0.3
|    |    +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
     |    +--- com.google.guava:guava:14.0.1 -> 33.5.0-jre (*)
     +--- com.google.guava:guava:14.0.1 -> 33.5.0-jre (*)
     |    \--- com.google.guava:guava:14.0.1 -> 33.5.0-jre (*)
|    +--- com.google.guava:guava:[24.1.1,34) -> 33.5.0-jre (c)
|    +--- com.google.guava:guava -> 33.5.0-jre
|    |    +--- com.google.guava:failureaccess:1.0.3
|    |    +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
|    +--- com.google.guava:guava:[24.1.1,34) -> 33.5.0-jre (c)
|    +--- com.google.guava:guava -> 33.5.0-jre
|    |    +--- com.google.guava:failureaccess:1.0.3
|    |    +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
     |    +--- com.google.guava:guava:14.0.1 -> 33.5.0-jre (*)
     +--- com.google.guava:guava:14.0.1 -> 33.5.0-jre (*)
     |    \--- com.google.guava:guava:14.0.1 -> 33.5.0-jre (*)

@emlun emlun requested a review from fdennis January 19, 2026 10:43
@github-actions
Copy link

github-actions bot commented Jan 19, 2026

Test Results

2 305 tests   2 297 ✅  1m 7s ⏱️
   46 suites      8 💤
   46 files        0 ❌

Results for commit 631134b.

@emlun emlun merged commit 631134b into main Jan 19, 2026
20 checks passed
@emlun emlun deleted the guava-34 branch January 19, 2026 11:30
@emlun emlun mentioned this pull request Jan 19, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fdennis fdennis fdennis approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Updating the Guava Dependency Range

2 participants

@emlun @fdennis