feat: calculate NDA from config instead of ATIS#46
Merged
Conversation
YuKitsune
changed the title
YuKitsune
force-pushed
the
feat/config-based-nda
branch
from
405b4ea to
461db56
Compare
- AircraftConnectivityCheckService -> AcarsConnectivityCheckService - CheckAircraftConnectionsRequest(Handler) -> RefreshAcarsCallsignsRequest(Handler) - ProcessHandoffsCommand(Handler) -> TransmitPendingNdaUplinksCommand(Handler) - HandoffService -> NdaUplinkService
- YBBB: replace SWY (subsector of KPL) with KPL - WIIF: remove redundant subsectors WIIFBD, WIIFIS and training position WIIFT; fix WIFF* typos to WIIF* - WAAF: remove redundant subsector WAAFNA and training positions WAAFT, WAAFX
Introduces AcarsStation record and renames store/method for clarity, aligning with server-side naming conventions.
Walk subsector -> parent -> grandparent when resolving NDA, collecting ATSU code candidates at each level. Select the first candidate that is currently online on the ACARS network, enabling per-subsector ATSU codes for FIRs that use individual Hoppie callsigns per position.
Expand YBBB and YMMM sector lists to include all enroute subsectors, and add missing WIIF/WAAF subsectors (WIIFBD, WIIFIS, WAAFNA).
Document hierarchy walk behaviour, online-aware candidate selection, and add a per-position logon code example (WIIF subsectors).
…lents Aligns server and plugin naming with the AcarsStation convention already established in the plugin-side store.
YuKitsune
force-pushed
the
feat/config-based-nda
branch
from
461db56 to
429a630
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces ATIS-based CPDLC code lookup with a static
AtsuCodesconfig, mapping ATSU logon codes to vatSys sector names. NDA is determined by walking the FDR route and finding the first sector whose ATSU differs from the current station.AtsuCodesandNdaRecalculationIntervalMinutesto plugin configAtsuCodessupports per-subsector logon codes for FIRs that use individual Hoppie callsigns per controller positionAcarsConnectedCallsignsStoretoAcarsStationStoreAtsuCodesfrom dictionary to typedAtsuCodeMappingrecordsCPDLC.jsonwith full sector/subsector mappings for YBBB, YMMM, WIIF, WAAF