Add links to the existing duplicate notices#501
Open
johnbillion wants to merge 2 commits into
Open
Conversation
Coverage Report for CI Build 26217146758Warning No base build found for commit Coverage: 60.207%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Every time I edit a post or page which has an in-progress duplicate, I'm frustrated that the editing screen doesn't show a link to the editing screen for the duplicate.
This message is informative but not actionable.
On a site with a large number of posts or pages, it can be laborious to find that post on the post listing screen in order to get the link to the in-progress duplicate. Each message about an existing duplicate should include a relevant link.
This PR adds a useful link to the editing screen, or the trash listing screen if the duplicate is in the trash:
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
I have intentionally appended the links to the existing admin notice messages in order to avoid invalidating existing translations. They might perhaps read better with inline links, but that would require inserting the link HTML into localisable strings which I'm not a big fan of doing.
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
UI changes
Documentation
Quality assurance
Innovation