Skip to content

Refactor fetchSponsors to use consume GitHub Sponsors#431

Open
LeoColomb wants to merge 4 commits intomainfrom
leo/gh-sponsors
Open

Refactor fetchSponsors to use consume GitHub Sponsors#431
LeoColomb wants to merge 4 commits intomainfrom
leo/gh-sponsors

Conversation

@LeoColomb
Copy link
Copy Markdown
Member

Closes #426
Fixes #427

@LeoColomb LeoColomb changed the title Refactor fetchSponsors to use consume GitHub sponsorships Refactor fetchSponsors to use consume GitHub Sponsors Apr 5, 2026
@LeoColomb LeoColomb marked this pull request as ready for review April 6, 2026 16:56
@LeoColomb LeoColomb requested a review from a team as a code owner April 6, 2026 16:56
@LeoColomb
Copy link
Copy Markdown
Member Author

LeoColomb commented Apr 6, 2026

Ready to be reviewed.
Website preview: https://leo-gh-sponsors.yourls-website.pages.dev/
The commit highlighting how to add a featured sponsor: 5f50368
The rest of the commits covers GitHub Sponsors integration.

@ozh
Copy link
Copy Markdown
Member

ozh commented Apr 10, 2026

If I understand correctly, this fetches profile logo and link from their opencollective profile ?

If the sponsors provides a custom link or, as in latest case, a custom logo, how do we manage ?

@ozh
Copy link
Copy Markdown
Member

ozh commented Apr 10, 2026

(or if the sponsor just has no Opencoll profile and just a github account)

@ozh
Copy link
Copy Markdown
Member

ozh commented Apr 10, 2026

Proposal for a solution with flexibility (custom sponsor logo, URL, name) and automation (checking on opencoll if the sponsorship is still on)

We would have a angel-sponsors.md file with a simple table like so:

sponsorname opencoll github URL logo
Some Company somecomp somecomp https://website/logo.png
Other Corp other-corp https://othercompany.co
Super Inc. superinc
BairesDev bairesdev BairesDev-LLC https://www.bairesdev.com/sponsoring-open-source-projects/ https://github.com/user-attachments/assets/caa67711-33df-4974-9bbe-cd2b7356712e

And the .js would check :

  • if there is an opencoll or GH handle : check if sponsorship is on
  • if there is an opencoll or GH : use fetched logo and URL from opencoll or Github, unless custom specified

@LeoColomb
Copy link
Copy Markdown
Member Author

LeoColomb commented Apr 11, 2026

If the sponsors provides a custom link or, as in latest case, a custom logo, how do we manage ?

We don't, or I don't believe we should offer.

(or if the sponsor just has no Opencoll profile and just a github account)

As titled, this is the goal of this PR, to consume GitHub Sponsors sponsors and integrate their assets.
Have you checked the preview, by any chance?

And the .js would check :

  • if there is an opencoll or GH handle : check if sponsorship is on
  • if there is an opencoll or GH : use fetched logo and URL from opencoll or Github, unless custom specified

Yes, this is what is done by the script already.
The only difference is the logo, which is not currently customzable.
The "custom" URL is the website URL provided by their GitHub Sponsors profile or OpenCollective profile, something they can edit and most do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "Angel sponsor" on homepage

2 participants