Skip to content

fix: release 빌드 문제 해결 #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
easyhooon merged 4 commits into from
Feb 14, 2026
Merged

fix: release 빌드 문제 해결 #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
57e8d5b
[BOOK-505] fix: release build success
easyhooon Feb 9, 2026
77b9f9b
[BOOK-505] chore: @param 어노테이션 추가
easyhooon Feb 9, 2026
4739102
[BOOK-505] chore: ConventionPlugin 내에 불필요한 개행 제거
easyhooon Feb 9, 2026
d24c3dc
[BOOK-505] chore: 토끼 리뷰 반영
easyhooon Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@

<service
android:name=".ReedFirebaseMessagingService"
android:exported="false">
android:exported="false"
tools:ignore="Instantiatable">
<intent-filter>
<action android:name="com.google.firebase.MESSAGING_EVENT" />
</intent-filter>
Expand Down
1 change: 0 additions & 1 deletion build-logic/src/main/kotlin/AndroidFeatureConventionPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

import com.google.devtools.ksp.gradle.KspExtension
import com.ninecraft.booket.convention.api
import com.ninecraft.booket.convention.applyPlugins
Expand Down
1 change: 0 additions & 1 deletion build-logic/src/main/kotlin/AndroidFirebaseConventionPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

import com.ninecraft.booket.convention.Plugins
import com.ninecraft.booket.convention.applyPlugins
import com.ninecraft.booket.convention.implementation
Expand Down
2 changes: 1 addition & 1 deletion ...otlin/com/ninecraft/booket/core/datastore/impl/datasource/DefaultLoginMethodDataSource.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import kotlinx.coroutines.flow.map
@SingleIn(DataScope::class)
@Inject
class DefaultLoginMethodDataSource(
@LoginMethodDataStore private val dataStore: DataStore<Preferences>,
@param:LoginMethodDataStore private val dataStore: DataStore<Preferences>,
Comment thread
coderabbitai[bot] marked this conversation as resolved.
) : LoginMethodDataSource {
override val recentLoginMethod: Flow<LoginMethod> = dataStore.data
.handleIOException()
Expand Down
4 changes: 2 additions & 2 deletions ...main/kotlin/com/ninecraft/booket/core/datastore/impl/datasource/DefaultTokenDataSource.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ import com.ninecraft.booket.core.datastore.api.datasource.TokenDataSource
import com.ninecraft.booket.core.datastore.impl.di.TokenDataStore
import com.ninecraft.booket.core.datastore.impl.security.CryptoManager
import com.ninecraft.booket.core.datastore.impl.util.handleIOException
import com.ninecraft.booket.core.di.DataScope
import com.orhanobut.logger.Logger
import dev.zacsweers.metro.Inject
import com.ninecraft.booket.core.di.DataScope
import dev.zacsweers.metro.SingleIn
import kotlinx.coroutines.flow.Flow
import kotlinx.coroutines.flow.first
Expand All @@ -20,7 +20,7 @@ import java.security.GeneralSecurityException
@SingleIn(DataScope::class)
@Inject
class DefaultTokenDataSource(
@TokenDataStore private val dataStore: DataStore<Preferences>,
@param:TokenDataStore private val dataStore: DataStore<Preferences>,
private val cryptoManager: CryptoManager,
) : TokenDataSource {
override val accessToken: Flow<String> = decryptStringFlow(ACCESS_TOKEN)
Expand Down
Loading