Skip to content

WP7.0 compatibility#694

Open
Akhill2020 wants to merge 4 commits into
mainfrom
issue/welcom-on-pro-activate
Open

WP7.0 compatibility#694
Akhill2020 wants to merge 4 commits into
mainfrom
issue/welcom-on-pro-activate

Conversation

@Akhill2020
Copy link
Copy Markdown
Contributor

@Akhill2020 Akhill2020 commented May 29, 2026

Description: Make Compatible with WP7.0 and fix error message on own via SC.
Clickup: https://app.clickup.com/t/86d358r5z

Summary by CodeRabbit

  • Bug Fixes

    • Improved Pro Connect configuration detection accuracy
    • Corrected Pro OAuth disconnect status messaging
  • Chores

    • Added WordPress 7.0 compatibility support
    • Released version 4.0.3

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ee18457e-ad11-4972-b379-fa3a78c0a231

📥 Commits

Reviewing files that changed from the base of the PR and between 619ae4f and 6f6089b.

📒 Files selected for processing (2)
  • package.json
  • readme.txt
✅ Files skipped from review due to trivial changes (2)
  • package.json
  • readme.txt

📝 Walkthrough

Walkthrough

This patch release enhances Pro Connect configuration detection to recognize own-OAuth health status and client_auth credentials, fixes Pro OAuth disconnect UI text rendering, and updates the plugin version to 4.0.3 with WordPress 7.0 compatibility documentation.

Changes

Version 4.0.3 Configuration Detection and Compatibility

Layer / File(s) Summary
Pro Connect configuration detection enhancement
includes/functions/admin.php
simcal_has_existing_pro_connect_configuration() now returns true when own-OAuth health is confirmed, and expands the credential check to include client_auth alongside client_id and client_secret.
UI text, version, and documentation updates
assets/js/admin.js, package.json, readme.txt
Pro OAuth disconnect status text now always renders the localized "Not Connected" string; version incremented to 4.0.3; readme "Tested up to" bumped to WordPress 7.0 with new changelog entry and trimmed historical entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • Xtendify/Simple-Calendar#692: Both PRs modify Pro Connect credential/config detection in includes/functions/admin.php, specifically the simcal_has_existing_pro_connect_configuration() function for own-OAuth and client_auth handling.
  • Xtendify/Simple-Calendar#680: Both PRs adjust Pro OAuth disconnect UI behavior in assets/js/admin.js, updating how disconnected status text is rendered.

Suggested reviewers

  • rosinghal
  • enginnk

Poem

🐰 A patch hops in with credential cheer,
OAuth health and client_auth now clear,
WordPress 7.0 tests complete,
Disconnect text now fresh and neat!
Version bumps make all things sweet. 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'WP7.0 compatibility' is partially related to the changeset but not fully descriptive of all changes made. While it correctly identifies WordPress 7.0 compatibility testing, it omits the significant fix to Pro Connect credential detection logic (client_auth field addition).
Docstring Coverage ✅ Passed Docstring coverage is 80.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue/welcom-on-pro-activate

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Akhill2020 Akhill2020 requested a review from rosinghal June 1, 2026 10:10
Comment thread includes/main.php Outdated
delete_option('simple-calendar_redirect_to_connect');
delete_option('simple_calendar_pro_redirect_to_connect');

if (function_exists('simcal_apply_connect_defaults_on_plugin_event')) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread includes/admin/connect-menu.php Outdated
return;
}

if (function_exists('simcal_maybe_dismiss_connect_welcome_if_already_configured')) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread includes/admin/connect-menu.php Outdated
<?php return;
}

if (function_exists('simcal_maybe_dismiss_connect_welcome_if_already_configured')) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread includes/admin/connect-menu.php Outdated
: (bool) get_option('simple-calendar_connect_welcome_dismissed_' . $welcome_context, false);

$show_welcome = $force_welcome || !$context_dismissed;
$already_configured =
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert please

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Akhill2020 Akhill2020 changed the title Welcome dismiss issue for existing user WP7.0 compatibility Jun 3, 2026
@Akhill2020 Akhill2020 requested a review from rosinghal June 3, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants