-
Notifications
You must be signed in to change notification settings - Fork 69
internal/debug: add integration with Grafana Pyroscope #33623 #1983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-upgrade
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds integration with Grafana Pyroscope, a continuous profiling platform, to enable comprehensive runtime profiling of the XDPoSChain node. The implementation allows users to collect and push CPU, memory, goroutine, mutex, and block profiling data to a Pyroscope server for analysis.
Changes:
- Added Pyroscope profiling support with configurable server URL, authentication, and custom tags
- Integrated Pyroscope lifecycle management into the application's debug setup and exit handlers
- Updated dependencies to include grafana/pyroscope-go v1.2.7 and related packages
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| internal/debug/pyroscope.go | New file implementing Pyroscope integration with flag definitions, initialization, and logger wrapper |
| internal/debug/flags.go | Integrated Pyroscope flags into the debug flags list and added startup/shutdown hooks |
| go.mod | Added pyroscope-go v1.2.7 dependency and updated testify to v1.10.0 |
| go.sum | Updated checksums for new and updated dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cb3c88c to
40f6a51
Compare
Proposed changes
This adds support for Grafana Pyroscope, a continuous profiling solution.
The client is configured similarly to metrics, i.e. run
Ref: ethereum#33623
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that